[TIP] Add copy to clipboard feature #142675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
release_note:skip
|
@PhilippeOberti there is a way to keep a width (240px). And make the indicators ID go to two or even three rows. So we can follow this design. (Sorry for not providing this view before). |
- add to indicators table cellActions using renderCellPopover property - add to barchart context menu - add to flyout
PhilippeOberti
force-pushed
the
indicator-table-cell-popover
branch
from
04bccfc to
91b42e0
Compare
@ferenrigue Done!!
|
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 11, 2022
- add to indicators table cellActions using renderCellPopover property - add to barchart context menu - add to flyout
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 14, 2022
- add to indicators table cellActions using renderCellPopover property - add to barchart context menu - add to flyout
maxcold
added
release_note:enhancement
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the copy to clipboard feature to the Threat Intelligence plugin.
Here are the places the copy capability has been added:
renderCellPopover(as mentioned in the doc when using a customrenderCellValue)To guarantee a good user experience, this PR also adds the other features to the Indicators table cellActions popover (see image below).
Similarly to
FilterIn,FilterOutandAddToTimelinecomponents, this PR adds 2 newCopyToClipboardcomponents: one as anEuiButtonEmptyand the second as anEuiContextMenu.Screen.Recording.2022-10-04.at.4.53.16.PM.mov
Fixes https://github.com/elastic/security-team/issues/4548
To do
Checklist
Delete any items that are not applicable to this PR.