Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] fix ml inference with api index #142673

Conversation

TattdCodeMonkey
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey commented Oct 4, 2022

Summary

Updates the the Pipelines logic to ensure you can configure ml inference pipelines with api-based indices.

@TattdCodeMonkey TattdCodeMonkey added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.5.0 v8.6.0 labels Oct 4, 2022
@TattdCodeMonkey TattdCodeMonkey requested a review from a team October 4, 2022 21:34
@TattdCodeMonkey TattdCodeMonkey force-pushed the rnorris/es/ml-pipelines-fix-api-index branch from c1e0a0d to 81330ea Compare October 4, 2022 21:36
Copy link
Contributor

@brianmcgue brianmcgue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add tests for these? Mostly thinking about for the logic file.

@TattdCodeMonkey
Copy link
Contributor Author

@brianmcgue yes. in fact I likely broke tests with these changes. will work on that now.

Updates the the Pipelines logic to ensure you can configure ml inference
pipelines with api-based indices.
@TattdCodeMonkey TattdCodeMonkey force-pushed the rnorris/es/ml-pipelines-fix-api-index branch from 81330ea to d0a6899 Compare October 4, 2022 22:05
@TattdCodeMonkey
Copy link
Contributor Author

@brianmcgue test added, which required a few minor changes to the logic but it all came out nicely.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.7MB 1.7MB +27.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TattdCodeMonkey TattdCodeMonkey merged commit c9af639 into elastic:main Oct 5, 2022
@TattdCodeMonkey TattdCodeMonkey deleted the rnorris/es/ml-pipelines-fix-api-index branch October 5, 2022 13:47
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 5, 2022
Updates the the Pipelines logic to ensure you can configure ml inference
pipelines with api-based indices.

(cherry picked from commit c9af639)
kibanamachine added a commit that referenced this pull request Oct 5, 2022
Updates the the Pipelines logic to ensure you can configure ml inference
pipelines with api-based indices.

(cherry picked from commit c9af639)

Co-authored-by: Rodney Norris <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
Updates the the Pipelines logic to ensure you can configure ml inference
pipelines with api-based indices.
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
Updates the the Pipelines logic to ensure you can configure ml inference
pipelines with api-based indices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.5.0 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants