-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enterprise Search] fix ml inference with api index #142673
[Enterprise Search] fix ml inference with api index #142673
Conversation
c1e0a0d
to
81330ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add tests for these? Mostly thinking about for the logic file.
@brianmcgue yes. in fact I likely broke tests with these changes. will work on that now. |
Updates the the Pipelines logic to ensure you can configure ml inference pipelines with api-based indices.
81330ea
to
d0a6899
Compare
@brianmcgue test added, which required a few minor changes to the logic but it all came out nicely. |
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Updates the the Pipelines logic to ensure you can configure ml inference pipelines with api-based indices. (cherry picked from commit c9af639)
Updates the the Pipelines logic to ensure you can configure ml inference pipelines with api-based indices. (cherry picked from commit c9af639) Co-authored-by: Rodney Norris <[email protected]>
Updates the the Pipelines logic to ensure you can configure ml inference pipelines with api-based indices.
Updates the the Pipelines logic to ensure you can configure ml inference pipelines with api-based indices.
Summary
Updates the the Pipelines logic to ensure you can configure ml inference pipelines with api-based indices.