Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

141253 further updates to alerts on detail pages #142669

Merged
merged 9 commits into from
Oct 5, 2022
Merged

141253 further updates to alerts on detail pages #142669

merged 9 commits into from
Oct 5, 2022

Conversation

jamster10
Copy link
Contributor

@jamster10 jamster10 commented Oct 4, 2022 •
edited by kibanamachine
Loading

Summary

As it relates to #141253.

This PR updates the components with requests from product, as well as bug fixes.

  • It adds the ability to navigate to a timeline from Alerts by Rule component with all status filters intact when clicking on a count.
  • Updates the Alert by Status component to be called 'Alerts By Severity' when on a detail page.
  • Allows global filters to apply to both components
  • Update text on Alert by Severity button to say 'Investigate in Timeline'

Recording 2022-10-04 at 15 43 43

Dev notes

The navigate to timeline implementation is temporary until completion of #142436

I think further work can be done to clean up these components as with the addition of needing all page filters, it need only accept a filters argument instead of additionalFilters and entityFilters.

Checklist

Delete any items that are not applicable to this PR.

@jamster10 jamster10 requested review from a team as code owners October 4, 2022 20:59
@jamster10 jamster10 self-assigned this Oct 4, 2022
@jamster10 jamster10 added bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.5.0 labels Oct 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@jamster10 jamster10 added the release_note:skip Skip the PR/issue when compiling release notes label Oct 4, 2022
stephmilovic
stephmilovic approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

@jamster10 jamster10 enabled auto-merge (squash) October 5, 2022 01:25
@jamster10 jamster10 mentioned this pull request Oct 5, 2022
Closed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.6MB 6.6MB +1.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jamster10

@jamster10 jamster10 merged commit 055f1c5 into elastic:main Oct 5, 2022
@kibanamachine kibanamachine mentioned this pull request Oct 5, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 5, 2022
@jamster10
141253 further updates to alerts on detail pages (elastic#142669)
038ef06 
* fix language on page as well as font size

* allow component to take additional filters

* add ability for AlertByStatus to accept additional filters

* update tests for Alert by Status

* remove unused import

* changes from code review

* update constant value from imported version

* fix bad test :(

Co-authored-by: Kristof-Pierre Cummings <[email protected]>
(cherry picked from commit 055f1c5)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 5, 2022
@kibanamachine @jamster10
141253 further updates to alerts on detail pages (#142669) (#142692)
b562bb0 
* fix language on page as well as font size

* allow component to take additional filters

* add ability for AlertByStatus to accept additional filters

* update tests for Alert by Status

* remove unused import

* changes from code review

* update constant value from imported version

* fix bad test :(

Co-authored-by: Kristof-Pierre Cummings <[email protected]>
(cherry picked from commit 055f1c5)

Co-authored-by: Kristof C <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@jamster10 @WafaaNasr
141253 further updates to alerts on detail pages (elastic#142669)
fc3cfbe 
* fix language on page as well as font size

* allow component to take additional filters

* add ability for AlertByStatus to accept additional filters

* update tests for Alert by Status

* remove unused import

* changes from code review

* update constant value from imported version

* fix bad test :(

Co-authored-by: Kristof-Pierre Cummings <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@jamster10 @WafaaNasr
141253 further updates to alerts on detail pages (elastic#142669)
e8d1009 
* fix language on page as well as font size

* allow component to take additional filters

* add ability for AlertByStatus to accept additional filters

* update tests for Alert by Status

* remove unused import

* changes from code review

* update constant value from imported version

* fix bad test :(

Co-authored-by: Kristof-Pierre Cummings <[email protected]>
@jamster10 jamster10 linked an issue Oct 20, 2022 that may be closed by this pull request
[Security Solution]Alert Status filter not applied in timeline investigation from alert by rule #141896
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephmilovic stephmilovic stephmilovic approved these changes

Assignees

@jamster10 jamster10

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution]Alert Status filter not applied in timeline investigation from alert by rule
5 participants
@jamster10 @elasticmachine @kibana-ci @kibanamachine @stephmilovic