Fixing flaky runSoon test
#142652
Merged
Fixing flaky runSoon test
#142652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymao1
changed the title
disable and runSoon testsrunSoon test
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
ymao1
added
Feature:Alerting
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 5, 2022
* Unskipping test * Unskipping test * Adding retries * Cleanup (cherry picked from commit f644fde)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 5, 2022
* Unskipping test * Unskipping test * Adding retries * Cleanup (cherry picked from commit f644fde) Co-authored-by: Ying Mao <[email protected]>
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 11, 2022
* Unskipping test * Unskipping test * Adding retries * Cleanup
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 14, 2022
* Unskipping test * Unskipping test * Adding retries * Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142564
Summary
Adding retries to run soon test. Sometimes when calling runSoon, the rule is already running and will return a 200, not a 204. Retrying until we get expected 204.
Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1361