Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.5] [Synthetics] preserve id field on monitor attributes (#142478) #142648

Merged
merged 1 commit into from
Oct 4, 2022
Merged

[8.5] [Synthetics] preserve id field on monitor attributes (#142478) #142648

merged 1 commit into from
Oct 4, 2022

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.5:

Questions ?

Please refer to the Backport tool documentation

@dominiqueclarke
[Synthetics] preserve id field on monitor attributes (elastic#142478)
62ca045 
* synthetics - preserve id field on monitor attributes

* adjust tests

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* adjust jest tests

* adjust tests

* adjust types

* adjust tests

* adjust types

* update tests

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 61342b3)
@kibanamachine kibanamachine requested a review from a team as a code owner October 4, 2022 17:43
@kibanamachine kibanamachine enabled auto-merge (squash) October 4, 2022 17:43
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Oct 4, 2022
@kibanamachine kibanamachine mentioned this pull request Oct 4, 2022
Merged
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #39 / apis uptime uptime REST endpoints uptime CRUD routes AddProjectMonitors project monitors - deletes monitors when keep stale is false

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1023.7KB 1023.9KB +245.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dominiqueclarke

@kibanamachine kibanamachine merged commit 9444b70 into elastic:8.5 Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dominiqueclarke dominiqueclarke

Labels
backport Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kibanamachine @elasticmachine @kibana-ci @dominiqueclarke