Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Custom pipelines update optimistically on creation #142639

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented Oct 4, 2022

Summary

This updates the create custom pipelines flow to optimistically update on creation, and makes the API wait for creation of pipelines before returning.

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 4, 2022
@sphilipse sphilipse requested a review from a team October 4, 2022 16:50
@sphilipse sphilipse enabled auto-merge (squash) October 4, 2022 18:10
@sphilipse sphilipse merged commit 7684d92 into elastic:main Oct 4, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.7MB 1.7MB +257.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 4, 2022
elastic#142639)

* [Enterprise Search] Custom pipelines update optimistically on creation

* Fix tests

(cherry picked from commit 7684d92)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 4, 2022
#142639) (#142660)

* [Enterprise Search] Custom pipelines update optimistically on creation

* Fix tests

(cherry picked from commit 7684d92)

Co-authored-by: Sander Philipse <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
elastic#142639)

* [Enterprise Search] Custom pipelines update optimistically on creation

* Fix tests
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
elastic#142639)

* [Enterprise Search] Custom pipelines update optimistically on creation

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.5.0 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants