-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enterprise Search] Custom pipelines update optimistically on creation #142639
Merged
sphilipse
merged 2 commits into
elastic:main
from
sphilipse:ent-search-2819-api-pipeline
Oct 4, 2022
Merged
[Enterprise Search] Custom pipelines update optimistically on creation #142639
sphilipse
merged 2 commits into
elastic:main
from
sphilipse:ent-search-2819-api-pipeline
Oct 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphilipse
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:EnterpriseSearch
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
labels
Oct 4, 2022
byronhulcher
approved these changes
Oct 4, 2022
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 4, 2022
elastic#142639) * [Enterprise Search] Custom pipelines update optimistically on creation * Fix tests (cherry picked from commit 7684d92)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 4, 2022
#142639) (#142660) * [Enterprise Search] Custom pipelines update optimistically on creation * Fix tests (cherry picked from commit 7684d92) Co-authored-by: Sander Philipse <[email protected]>
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 11, 2022
elastic#142639) * [Enterprise Search] Custom pipelines update optimistically on creation * Fix tests
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 14, 2022
elastic#142639) * [Enterprise Search] Custom pipelines update optimistically on creation * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
release_note:skip
Skip the PR/issue when compiling release notes
Team:EnterpriseSearch
v8.5.0
v8.6.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This updates the create custom pipelines flow to optimistically update on creation, and makes the API wait for creation of pipelines before returning.