Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution] Link to the correct subscription upgrade "page/flow" #142630

Conversation

janmonschke
Copy link
Contributor

@janmonschke janmonschke commented Oct 4, 2022

Summary

From the insights module, we were linking to elastic.co/pricing/ for the lack of a better link during development. Now that we're launching the feature as GA in 8.5, we want to link to Kibana's internal subscription flow.

@janmonschke janmonschke added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 4, 2022
@janmonschke janmonschke self-assigned this Oct 4, 2022
@janmonschke janmonschke requested a review from a team as a code owner October 4, 2022 16:05
@janmonschke
Copy link
Contributor Author

@elasticmachine merge upstream

@janmonschke
Copy link
Contributor Author

@elasticmachine merge upstream

@janmonschke janmonschke enabled auto-merge (squash) October 5, 2022 09:08
@janmonschke
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.6MB 6.6MB +117.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @janmonschke

@janmonschke janmonschke merged commit 25ba3c7 into elastic:main Oct 5, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 5, 2022
…w" (elastic#142630)

* fix: link to the correct subscription upgrade "page/flow"

* test: fix tests

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 25ba3c7)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 5, 2022
…w" (#142630) (#142732)

* fix: link to the correct subscription upgrade "page/flow"

* test: fix tests

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 25ba3c7)

Co-authored-by: Jan Monschke <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
…w" (elastic#142630)

* fix: link to the correct subscription upgrade "page/flow"

* test: fix tests

Co-authored-by: Kibana Machine <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
…w" (elastic#142630)

* fix: link to the correct subscription upgrade "page/flow"

* test: fix tests

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.5.0 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants