Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Remove Fleet server upgrade modal #142622

Merged
merged 3 commits into from
Oct 4, 2022
Merged

[Fleet] Remove Fleet server upgrade modal #142622

merged 3 commits into from
Oct 4, 2022

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Oct 4, 2022 •
edited
Loading

Summary

Related to #137785

In 7.13 we introduced a modal shown when upgrading to Fleet server #97413

That modal is not relevant anymore and we should probably clean the related code as it's done in that PR.

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.6.0 labels Oct 4, 2022
@nchaulet nchaulet self-assigned this Oct 4, 2022
@nchaulet nchaulet requested a review from a team as a code owner October 4, 2022 15:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet
Copy link
Member Author

nchaulet commented Oct 4, 2022

@elasticmachine merge upstream

criamico
criamico approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 767 766 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 916.4KB 911.6KB -4.8KB

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/saved-objects-service.html#_mappings

id before after diff
ingest_manager_settings 4 3 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 87fa95d into elastic:main Oct 4, 2022
@nchaulet nchaulet deleted the maintenance-remove-fleet-server-upgrade-modal branch October 4, 2022 17:18
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 4, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@nchaulet @WafaaNasr
[Fleet] Remove Fleet server upgrade modal (elastic#142622)
74df3f3
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@nchaulet @WafaaNasr
[Fleet] Remove Fleet server upgrade modal (elastic#142622)
a392ea3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@criamico criamico criamico approved these changes

Assignees

@nchaulet nchaulet

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nchaulet @elasticmachine @kibana-ci @criamico @kibanamachine