Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Unskip flaky api test #142595

Merged
merged 1 commit into from
Oct 4, 2022
Merged

[Uptime] Unskip flaky api test #142595

merged 1 commit into from
Oct 4, 2022

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Oct 4, 2022 •
edited by kibanamachine
Loading

Summary

Fixes #136541
Fixes #136542

This was most likely an upstream es issue which got fixed recently elastic/elasticsearch#90130

Flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1354

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #45 / analytics instrumented events from the browser Loaded Dashboard full loaded dashboard should emit the "Loaded Dashboard" event when done loading complex dashboard

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 marked this pull request as ready for review October 4, 2022 14:20
@shahzad31 shahzad31 requested a review from a team as a code owner October 4, 2022 14:20
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.5.0 v8.6.0 labels Oct 4, 2022
dominiqueclarke
dominiqueclarke approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31 shahzad31 merged commit b798f9f into elastic:main Oct 4, 2022
@shahzad31 shahzad31 deleted the unskip-test branch October 4, 2022 14:23
@kibanamachine kibanamachine mentioned this pull request Oct 4, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 4, 2022
@shahzad31
[Uptime] Unskip flaky api test (elastic#142595)
45075fb 
(cherry picked from commit b798f9f)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 4, 2022
@kibanamachine @shahzad31
[Uptime] Unskip flaky api test (#142595) (#142613)
178230a 
(cherry picked from commit b798f9f)

Co-authored-by: Shahzad <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@shahzad31 @WafaaNasr
[Uptime] Unskip flaky api test (elastic#142595)
a4b46fb
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@shahzad31 @WafaaNasr
[Uptime] Unskip flaky api test (elastic#142595)
f585200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
4 participants
@shahzad31 @kibana-ci @kibanamachine @dominiqueclarke