Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Add getByTestSubj command for e2e tests #142591

Merged
merged 1 commit into from
Oct 4, 2022
Merged

[APM] Add getByTestSubj command for e2e tests #142591

merged 1 commit into from
Oct 4, 2022

Conversation

gbamparop
Copy link
Contributor

Summary

There are many instances where testSubjects are used to get DOM elements in e2e tests. This PR adds a getByTestSubj command to replace usages of cy.get('[data-test-subj="${selector}"]').

@gbamparop gbamparop added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes v8.6.0 labels Oct 4, 2022
@gbamparop gbamparop requested a review from a team as a code owner October 4, 2022 12:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

yngrdyn
yngrdyn approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍻

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #17 / alerting api integration spaces only Alerting runSoon should successfully run rule where scheduled task id is same as rule id

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gbamparop gbamparop merged commit 9e88bc9 into elastic:main Oct 4, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 4, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@gbamparop @WafaaNasr
Add getByTestSubj command (elastic#142591)
4e688c8
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@gbamparop @WafaaNasr
Add getByTestSubj command (elastic#142591)
908ada8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yngrdyn yngrdyn yngrdyn approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gbamparop @elasticmachine @kibana-ci @sorenlouv @yngrdyn @kibanamachine