Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution] Fix for an unxpected empty state in Insights #142580

Conversation

janmonschke
Copy link
Contributor

@janmonschke janmonschke commented Oct 4, 2022

Summary

#142576 describes a bug where the "related alerts by process ancestry" insights - module is showing an empty state and it seems stuck:

Screenshot 2022-09-30 at 17 24 23

The underlying issue for this behaviour was that the component did not handle all API responses correctly. In case of an undefined response for alertIds, the component would return null instead of an error/empty state message.

Checklist

@janmonschke janmonschke added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 4, 2022
@janmonschke janmonschke self-assigned this Oct 4, 2022
@janmonschke janmonschke requested review from a team as code owners October 4, 2022 11:02
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@janmonschke janmonschke enabled auto-merge (squash) October 4, 2022 13:21
@janmonschke
Copy link
Contributor Author

@elasticmachine merge upstream

@janmonschke janmonschke merged commit 2a1df2d into elastic:main Oct 4, 2022
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #42 / Reporting Functional Tests with forced timeout adds a visual warning in the report output

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.6MB 6.6MB +25.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @janmonschke

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 4, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 5, 2022
(cherry picked from commit 2a1df2d)

Co-authored-by: Jan Monschke <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.5.0 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants