Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename appState.vis to appState.visState #14258

Closed
wants to merge 3 commits into from
Closed

rename appState.vis to appState.visState #14258

wants to merge 3 commits into from

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Oct 3, 2017 •
edited
Loading

Closes #14189

@thomasneirynck thomasneirynck added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v6.0.0 review labels Oct 3, 2017
@ppisljar
Copy link
Member

ppisljar commented Oct 3, 2017

jenkins, test this

@ppisljar
Copy link
Member

ppisljar commented Oct 3, 2017 •
edited
Loading

nice! i would think this would have bigger footprint

tests are failling, not sure if its related

ppisljar
ppisljar approved these changes Oct 3, 2017
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on passing tests

@thomasneirynck
Copy link
Contributor Author

jenkins, test this

@thomasneirynck
Copy link
Contributor Author

jenkins, test this

1 similar comment
@thomasneirynck
Copy link
Contributor Author

jenkins, test this

@epixa epixa added v6.0.1 and removed v6.0.0 labels Nov 13, 2017
@thomasneirynck
Copy link
Contributor Author

closing, this has been languishing for a while now, can reopen if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

Assignees
No one assigned
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review stalled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasneirynck @ppisljar @epixa