Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIP] Add update status component #142560

Merged
merged 1 commit into from
Oct 4, 2022
Merged

[TIP] Add update status component #142560

merged 1 commit into from
Oct 4, 2022

Conversation

lgestc
Copy link
Contributor

@lgestc lgestc commented Oct 4, 2022

Summary

This PR adds the update status label, also fixes some issues I've found in the e2e test suite.

image

Checklist

Delete any items that are not applicable to this PR.

@lgestc lgestc added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team: Protections Experience labels Oct 4, 2022
@lgestc lgestc requested a review from PhilippeOberti October 4, 2022 08:55
@lgestc lgestc requested a review from a team as a code owner October 4, 2022 08:55
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
threatIntelligence 209 211 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
threatIntelligence 112.5KB 113.1KB +685.0B

History

  • 💔 Build #77832 failed 83ae05b0503d777183ffe276f36e594d96395bed
  • 💔 Build #77819 failed e165654552edca58a85fc012fceb1eefedff6d86

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lgestc lgestc enabled auto-merge (squash) October 4, 2022 11:57
PhilippeOberti
PhilippeOberti approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lgestc lgestc merged commit 001d44c into elastic:main Oct 4, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@lgmys @WafaaNasr
[TIP] Add update status component (elastic#142560)
2262d44
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@lgmys @WafaaNasr
[TIP] Add update status component (elastic#142560)
b30ce15
@maxcold
Copy link
Contributor

maxcold commented Oct 20, 2022

not a big thing but we forgot to add a story for UpdateStatus component

@maxcold maxcold added release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. and removed release_note:skip Skip the PR/issue when compiling release notes labels Nov 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:enhancement Team: Protections Experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lgestc @kibana-ci @maxcold @elasticmachine @PhilippeOberti @kibanamachine