-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIP] Add integrations on the threat_intelligence url now routes to the threat_intel category #142538
[TIP] Add integrations on the threat_intelligence url now routes to the threat_intel category #142538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks okay but can we have an e2e test for this? just so whe know if anything changes in terms of navigation - that would prevent the correct page to load
@lgmys I'm happy to write an e2e test, but you don't think this unit test would be enough? https://github.com/elastic/kibana/pull/142538/files#diff-ba704d8879cdcd28e1fba7e29494220cbc4898716da254d457dfd17957e3046cR106 Or did you mean add an e2e test in our plugin, to make sure that nobody modifies the logic in the Security Solution plugin without us knowing? |
Yes, something that will give us a heads up if this approach no longer redirects the user where we want |
…he threat_intel category
14cccf0
to
b6483ff
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…he threat_intel category (elastic#142538)
…he threat_intel category (elastic#142538)
Pinging @elastic/security-solution (Team: SecuritySolution) |
Context
The Integrations screen has many categories. The GlobalHeader is where we set the url to navigate to the Integrations page. Most (if not all) pages within the Security Solution plugin are using the default constant which filters the integrations with the
Security
category.The Threat Intelligence plugin wants to use the
Threat Intelligence
category to improve user experience.Summary
This PR allows routes starting with threat_intelligence to route to the Integrations page with the
Threat Intelligence
category selected. The behavior for all other pages remains identical to the current logic.Screen.Recording.2022-10-03.at.5.27.38.PM.mov
Fixes https://github.com/elastic/security-team/issues/5008
Checklist