Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIP] Add integrations on the threat_intelligence url now routes to the threat_intel category #142538

Merged

Conversation

PhilippeOberti
Copy link
Contributor

@PhilippeOberti PhilippeOberti commented Oct 3, 2022

Context

The Integrations screen has many categories. The GlobalHeader is where we set the url to navigate to the Integrations page. Most (if not all) pages within the Security Solution plugin are using the default constant which filters the integrations with the Security category.
The Threat Intelligence plugin wants to use the Threat Intelligence category to improve user experience.

Summary

This PR allows routes starting with threat_intelligence to route to the Integrations page with the Threat Intelligence category selected. The behavior for all other pages remains identical to the current logic.

Screen.Recording.2022-10-03.at.5.27.38.PM.mov

Fixes https://github.com/elastic/security-team/issues/5008

Checklist

@PhilippeOberti PhilippeOberti requested a review from a team as a code owner October 3, 2022 22:35
@PhilippeOberti PhilippeOberti added release_note:skip Skip the PR/issue when compiling release notes Team: Protections Experience v8.6.0 labels Oct 3, 2022
Copy link
Contributor

@lgestc lgestc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay but can we have an e2e test for this? just so whe know if anything changes in terms of navigation - that would prevent the correct page to load

@PhilippeOberti
Copy link
Contributor Author

PhilippeOberti commented Oct 4, 2022

looks okay but can we have an e2e test for this? just so whe know if anything changes in terms of navigation - that would prevent the correct page to load

@lgmys I'm happy to write an e2e test, but you don't think this unit test would be enough? https://github.com/elastic/kibana/pull/142538/files#diff-ba704d8879cdcd28e1fba7e29494220cbc4898716da254d457dfd17957e3046cR106

Or did you mean add an e2e test in our plugin, to make sure that nobody modifies the logic in the Security Solution plugin without us knowing?

@lgestc
Copy link
Contributor

lgestc commented Oct 4, 2022

Yes, something that will give us a heads up if this approach no longer redirects the user where we want

@PhilippeOberti PhilippeOberti force-pushed the threat-intel-add-integrations branch from 14cccf0 to b6483ff Compare October 4, 2022 20:05
@PhilippeOberti PhilippeOberti requested a review from a team as a code owner October 4, 2022 20:05
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.6MB 6.6MB +29.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 263.8KB 264.0KB +234.0B

History

  • 💚 Build #77750 succeeded 14cccf0a9f2920920c49086dfb09e2ccfe037ef7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@PhilippeOberti PhilippeOberti requested a review from lgestc October 4, 2022 22:07
Copy link
Contributor

@nkhristinin nkhristinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PhilippeOberti PhilippeOberti merged commit a6f013b into elastic:main Oct 5, 2022
@PhilippeOberti PhilippeOberti deleted the threat-intel-add-integrations branch October 5, 2022 14:05
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 5, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@maxcold maxcold added release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. and removed release_note:skip Skip the PR/issue when compiling release notes labels Nov 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement Team: Protections Experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants