[Security Solution][Analyzer] Make all analyzer apis have time range as optional #142536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kqualters-elastic
added
release_note:skip
|
Pinging @elastic/security-threat-hunting (Feature:Resolver) |
joeypoon
approved these changes
Oct 3, 2022
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
janmonschke
reviewed
Oct 4, 2022
| ); | ||
| const timestamps = unboundedTree | ||
| .map((event) => firstNonNullValue(event.data['@timestamp'])) | ||
| .sort(); |
There was a problem hiding this comment.
Do we expect unboundedTree to potentially contain thousands of entries?
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 4, 2022
…as optional (elastic#142536) (cherry picked from commit 890bf74)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 4, 2022
…as optional (#142536) (#142601) (cherry picked from commit 890bf74) Co-authored-by: Kevin Qualters <[email protected]>
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 11, 2022
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pr fixes 2 small issues with the analyzer autotune functionality. The first was due to the frontend assuming the process events were sorted by time, which is only true for simple trees, more complex trees follow an ordering described in this comment https://github.com/elastic/kibana/blob/main/x-pack/plugins/security_solution/server/endpoint/routes/resolver/tree/utils/fetch.ts#L182-#L203. The frontend now sorts the response and both trees that are unbounded and trees with a timerange that contain all events show the same results. The second issue is that the requests made to populate the panel were still including the user supplied time range, so only partial results were being displayed there. All 3 analyzer apis now have timeRange as an optional parameter.
Before:
After:
Valid timerange:
Nonvalid timerange:
Checklist