Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Guided onboarding] Fix steps status #142526

Merged

Conversation

alisonelizabeth
Copy link
Contributor

@alisonelizabeth alisonelizabeth commented Oct 3, 2022

This PR fixes the "inactive" and "complete" states for the guide steps.

Fixes #140981
Also addresses part of #141223 (leaving issue open for any other polish items that come up)

Screen Shot 2022-10-03 at 7 52 47 PM

@alisonelizabeth alisonelizabeth added release_note:skip Skip the PR/issue when compiling release notes Team:Journey/Onboarding Platform Journey Onboarding team labels Oct 3, 2022
@alisonelizabeth alisonelizabeth marked this pull request as ready for review October 4, 2022 00:01
@alisonelizabeth alisonelizabeth requested a review from a team as a code owner October 4, 2022 00:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-onboarding (Team:Journey/Onboarding)

@cindychangy
Copy link
Contributor

cindychangy commented Oct 4, 2022

@alisonelizabeth: Thanks for these changes, I made one suggestion for the font weight, and there is one thing missing: when the user clicks on an accordion step to expand it, the title should turn from gray to black. I think (you may have a better method) you could target it in the components/guide_panel.styles.ts file inside of the flyoutBody declaration:

flyoutBody: css`
   .euiFlyoutBody__overflowContent {
     .....
     .euiAccordion-isOpen .euiText/$stepTitle {
        color: ${euiTheme.colors.title};
    }
  }

@alisonelizabeth
Copy link
Contributor Author

Thanks for the review @cindychangy!

and there is one thing missing: when the user clicks on an accordion step to expand it, the title should turn from gray to black.

Good catch. Should be fixed via fe8e6fc.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
guidedOnboarding 16.0KB 16.2KB +207.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @alisonelizabeth! changes LGTM 👍

@alisonelizabeth alisonelizabeth merged commit bd68933 into elastic:main Oct 4, 2022
@alisonelizabeth alisonelizabeth deleted the guided_onboarding/step_status branch October 4, 2022 19:42
@kibanamachine kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Oct 4, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Journey/Onboarding Platform Journey Onboarding team v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Guided onboarding] Support inactive/completed steps
6 participants