-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Guided onboarding] Fix steps status #142526
[Guided onboarding] Fix steps status #142526
Conversation
Pinging @elastic/platform-onboarding (Team:Journey/Onboarding) |
@alisonelizabeth: Thanks for these changes, I made one suggestion for the font weight, and there is one thing missing: when the user clicks on an accordion step to expand it, the title should turn from gray to black. I think (you may have a better method) you could target it in the
|
src/plugins/guided_onboarding/public/components/guide_panel_step.styles.ts
Outdated
Show resolved
Hide resolved
…ep.styles.ts Co-authored-by: Cindy Chang <[email protected]>
Thanks for the review @cindychangy!
Good catch. Should be fixed via fe8e6fc. |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @alisonelizabeth! changes LGTM 👍
This PR fixes the "inactive" and "complete" states for the guide steps.
Fixes #140981
Also addresses part of #141223 (leaving issue open for any other polish items that come up)