Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIP] Add full screen feature for indicators table #142519

Merged
merged 3 commits into from
Oct 4, 2022
Merged

[TIP] Add full screen feature for indicators table #142519

merged 3 commits into from
Oct 4, 2022

Conversation

PhilippeOberti
Copy link
Contributor

Summary

This PR enables the full screen mode on the indicators table.

Screen.Recording.2022-10-03.at.2.18.16.PM.mov

Fixes https://github.com/elastic/security-team/issues/4546

Checklist

  • Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
  • Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
  • This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

@PhilippeOberti PhilippeOberti requested a review from a team as a code owner October 3, 2022 19:20
@PhilippeOberti PhilippeOberti added release_note:skip Skip the PR/issue when compiling release notes 8.6 candidate Team: Protections Experience labels Oct 3, 2022
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #45 / Reporting Functional Tests with forced timeout adds a visual warning in the report output

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

lgestc
lgestc approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@lgestc lgestc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@PhilippeOberti PhilippeOberti merged commit 5add1f9 into elastic:main Oct 4, 2022
@PhilippeOberti PhilippeOberti deleted the indicator-table-fulls-creen branch October 4, 2022 13:45
@kibanamachine kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Oct 4, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@PhilippeOberti @WafaaNasr
[TIP] Add full screen feature for indicators table (elastic#142519)
307e330 
[TIP] Add full screen feature for indicators table
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@PhilippeOberti @WafaaNasr
[TIP] Add full screen feature for indicators table (elastic#142519)
c9b609a 
[TIP] Add full screen feature for indicators table
@maxcold maxcold added release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. and removed release_note:skip Skip the PR/issue when compiling release notes labels Nov 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgestc lgestc lgestc approved these changes

Assignees
No one assigned
Labels
8.6 candidate backport:skip This commit does not require backporting release_note:enhancement Team: Protections Experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PhilippeOberti @kibana-ci @elasticmachine @lgestc @maxcold @kibanamachine