Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIP] Reorganize table folder within indicators module #142510

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

PhilippeOberti
Copy link
Contributor

Summary

Part of a bigger cleanup and reorganization of the Threat Intelligence plugin (see https://github.com/elastic/security-team/issues/4983) this PR focuses on the barchart section of our plugin.

  • consolidate components that are only used for the indicators barchart
  • remove the words indicators and indicator from folder and file names
  • remove word barchart from folder and file names
  • move hooks and utils files only used in barchart
  • rename index.tsx to index.ts
  • cleanup imports

No UI changes.

Here's the folder's structure:

├── components
│   ├── actions_row_cell.tsx
│   ├── cell_actions.tsx
│   ├── cell_renderer.tsx
│   ├── field_browser
│   │   ├── field_browser.test.tsx
│   │   ├── field_browser.tsx
│   │   └── index.ts
│   ├── index.ts
│   └── open_flyout_button
│       ├── index.ts
│       ├── open_flyout_button.stories.tsx
│       ├── open_flyout_button.test.tsx
│       └── open_flyout_button.tsx
├── contexts
│   ├── context.ts
│   └── index.ts
├── hooks
│   ├── index.ts
│   ├── use_column_settings.test.ts
│   ├── use_column_settings.ts
│   ├── use_toolbar_options.test.tsx
│   └── use_toolbar_options.tsx
├── index.tsx
├── table.stories.tsx
├── table.test.tsx
└── table.tsx

@PhilippeOberti PhilippeOberti requested a review from a team as a code owner October 3, 2022 18:32
@PhilippeOberti PhilippeOberti added release_note:skip Skip the PR/issue when compiling release notes Team: Protections Experience v8.6.0 labels Oct 3, 2022
@PhilippeOberti PhilippeOberti force-pushed the ti-reorg-table branch 2 times, most recently from a7a7a1c to 6710a13 Compare October 4, 2022 15:14
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
threatIntelligence 211 216 +5

History

  • 💔 Build #77993 failed 6710a135d123221ec1aef8faf96012f9c158065b
  • 💔 Build #77954 failed a7a7a1c358360a8c95853d455eeade33a1927007
  • 💚 Build #77701 succeeded 7972c97a030fc67b3c1a25a8949b36d8a646af74
  • 💔 Build #77666 failed ad6ec2ce6bc2aab67c61076aeaa42bc89ad4f2e4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@PhilippeOberti PhilippeOberti merged commit 035720b into elastic:main Oct 4, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 4, 2022
@PhilippeOberti PhilippeOberti deleted the ti-reorg-table branch October 4, 2022 17:43
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Protections Experience v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants