Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

render the grid only if we have alerts #142481

Merged
merged 3 commits into from
Oct 5, 2022
Merged

render the grid only if we have alerts #142481

merged 3 commits into from
Oct 5, 2022

Conversation

jcger
Copy link
Contributor

@jcger jcger commented Oct 3, 2022 •
edited by kibanamachine
Loading

Summary

Hopefully fixes #142340

@jcger jcger added release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.5.0 ci:cloud-deploy Create or update a Cloud deployment v8.6.0 labels Oct 3, 2022
@jcger jcger marked this pull request as ready for review October 3, 2022 14:42
@jcger jcger requested a review from a team as a code owner October 3, 2022 14:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@EricDavisX EricDavisX added ci:cloud-redeploy Always create a new Cloud deployment and removed ci:cloud-deploy Create or update a Cloud deployment labels Oct 3, 2022
@jcger jcger added ci:cloud-redeploy Always create a new Cloud deployment and removed ci:cloud-redeploy Always create a new Cloud deployment labels Oct 5, 2022
@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 5, 2022 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 672.7KB 672.7KB -1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@EricDavisX
Copy link
Contributor

Did some quick tests on the pr - it looks good to me to get reviews and push it forward.

@jcger jcger merged commit b3ebe13 into elastic:main Oct 5, 2022
@kibanamachine kibanamachine mentioned this pull request Oct 5, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 5, 2022
@jcger
[RAM] render the grid only if we have alerts (elastic#142481)
525e952 
(cherry picked from commit b3ebe13)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 5, 2022
@kibanamachine @jcger
[RAM] render the grid only if we have alerts (#142481) (#142740)
bffe298 
(cherry picked from commit b3ebe13)

Co-authored-by: Julian Gernun <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@jcger @WafaaNasr
[RAM] render the grid only if we have alerts (elastic#142481)
aea36b9
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@jcger @WafaaNasr
[RAM] render the grid only if we have alerts (elastic#142481)
11c81fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

Assignees
No one assigned
Labels
ci:cloud-redeploy Always create a new Cloud deployment release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.5.0 v8.6.0
Projects
No open projects
AppEx: ResponseOps - Rules & Alerts Management
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ResponseOps][BUG] - Alert table is too small when there is one alert
6 participants
@jcger @elasticmachine @kibana-ci @EricDavisX @kibanamachine @XavierM