[ResponseOps][Stack Connectors] Opsgenie connector UI #142411

jonathan-buttner · 2022-09-30T21:01:25Z

This PR implements the Opsgenie connector's UI for phase 1 of the issue.

For creating the alert it includes the fields: message, description, and alias. For closing the alert it includes the fields: note and alias.

Notes

This PR does not include the Opsgenie logo. We're still waiting to get that.

Testing

Refer to this PR's testing section for details on how to create an Opsgenie environment: #142164

Examples

Connector card icon

Create Opsgenie Connector

Test Connector

Creating alert

Closing alert

Create alert when rules fires

Close alert when rule recovers

Release Notes

This feature allows users to create and close alerts within Opsgenie.

…e-ui

elasticmachine · 2022-10-13T19:45:50Z

Pinging @elastic/response-ops (Team:ResponseOps)

jonathan-buttner · 2022-10-13T19:46:32Z

x-pack/plugins/stack_connectors/public/connector_types/stack/opsgenie/logo.tsx

+import React from 'react';
+import { LogoProps } from '../../types';
+
+const Logo = (props: LogoProps) => <EuiIcon type="casesApp" size="xl" />;


Just using the cases logo until we get the Opsgenie one.

jonathan-buttner · 2022-10-13T19:49:05Z

x-pack/plugins/stack_connectors/server/connector_types/index.ts

@@ -46,7 +46,6 @@ export {
  SlackConnectorTypeId,
  TeamsConnectorTypeId,
  WebhookConnectorTypeId,
-  OpsgenieConnectorTypeId,


Moved this to the common folder so that the ui can access it too.

jonathan-buttner · 2022-10-13T19:50:18Z

x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alert_create_flyout.ts

@@ -62,55 +62,14 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
    await nameInput.click();
  }

-  async function defineIndexThresholdAlert(alertName: string) {


Moved this into the rules.common service.

jonathan-buttner · 2022-10-13T19:51:43Z

x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/connectors/general.ts

@@ -279,22 +289,6 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
    });
  });

-  async function createConnector(connectorName: string) {


Moved these to the utils.ts file. Maybe we should move them to the service api like cases 🤷‍♂️

cnasikas · 2022-10-18T06:47:03Z

x-pack/plugins/stack_connectors/public/connector_types/stack/opsgenie/params.tsx

+
+  const currentSubAction = useRef<string>(subAction ?? OpsgenieSubActions.CreateAlert);
+
+  const actionOptions = [


nit: this can be moved outside the component as it is not depend on the props or the state.

cnasikas · 2022-10-18T06:56:38Z

x-pack/test/functional/services/actions/common.ts

+      const createBtnIsVisible = await createBtn.isDisplayed();
+      if (createBtnIsVisible) {
+        await createBtn.click();


I think is better to fail if the button does not exist. You can use testSubjets.existsOrFail.

cnasikas · 2022-10-18T06:58:15Z

x-pack/test/functional/services/actions/common.ts

+  const testSubjects = getService('testSubjects');
+
+  return {
+    async clickCreateFirstConnectorButton() {


nit: the naming is a bit confusing. Maybe we can call it createConnectorFromEmptyPrompt or similar.

cnasikas · 2022-10-18T07:03:16Z

x-pack/test/functional/services/actions/opsgenie.ts

+      await find.clickByCssSelector(
+        '[data-test-subj="create-connector-flyout-save-btn"]:not(disabled)'
+      );
+    },


Maybe we can do:

Suggested change

await find.clickByCssSelector(

'[data-test-subj="create-connector-flyout-save-btn"]:not(disabled)'

);

},

const button = await testSubjects.find("create-connector-flyout-save-btn")

const isDisabled = await button.isEnabled() // or button.getAttribute('disabled')

expect(isDisabled).toBe(false)

},

cnasikas · 2022-10-18T07:10:59Z

x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/connectors/utils.ts

+  return connector;
+};
+
+export const getConnector = async (


Maybe we should use get the connector by ID: https://www.elastic.co/guide/en/kibana/current/get-connector-api.html

The reason to use this function is when we don't have the connector id. A few of the tests create the connector via the UI instead of an API call.

I'll update the name to getConnectorByName

Oh, I see. Thanks!

cnasikas · 2022-10-18T07:12:08Z

x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/connectors/utils.ts

+    })
+    .expect(200);
+
+  await common.navigateToApp('triggersActionsConnectors');


I think API utils functions should not do side effects like navigating to UI components.

cnasikas · 2022-10-18T07:12:37Z

x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/connectors/utils.ts

+  getService: FtrProviderContext['getService'];
+}) => {
+  const common = getPageObject('common');
+  const supertest = getService('supertest');


I think it is better if we pass the supertest directly as an argument.

cnasikas · 2022-10-18T07:13:24Z

x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/connectors/utils.ts

+import { FtrProviderContext } from '../../../ftr_provider_context';
+import { getTestActionData } from '../../../lib/get_test_data';
+
+export const createConnectorAndObjectRemover = async ({


nit: As it is not generic and creates a slack connector maybe is better to rename it to createSlackConnectorAndObjectRemover

Great point.

cnasikas

Code LTGM! I tested and everything is working as expected. Thank you so much for adding the test services 🚀

kibana-ci · 2022-10-18T19:54:37Z

💚 Build Succeeded

Buildkite Build
Commit: ec09bcc

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`stackConnectors`	133	141	+8

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`stackConnectors`	2	4	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`stackConnectors`	327.5KB	337.8KB	+10.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`stackConnectors`	20.8KB	22.5KB	+1.6KB

Unknown metric groups

API count

id	before	after	diff
`stackConnectors`	2	4	+2

async chunk count

id	before	after	diff
`stackConnectors`	50	54	+4

ESLint disabled line counts

id	before	after	diff
`stackConnectors`	67	72	+5

Total ESLint disabled count

id	before	after	diff
`stackConnectors`	71	76	+5

History

💚 Build #81085 succeeded f67d32b
💚 Build #80801 succeeded 3d97483
💔 Build #80743 failed 33ac77c
💔 Build #80264 failed 69529d6
💔 Build #80144 failed 7840529
💔 Build #79958 failed f029784

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Starting opsgenie backend * Adding more integration tests * Updating readme * Starting ui * Adding hash and alias * Fixing tests * Switch to platinum for now * Adding server side translations * Fixing merge issues * Fixing file location error * Working ui * Default alias is working * Almost working validation fails sometimes * Adding end to end tests * Adding more tests * Adding note and description fields * Removing todo * Fixing test errors * Addressing feedback * Trying to fix test flakiness

jonathan-buttner added 5 commits September 28, 2022 17:38

Starting opsgenie backend

33bcdcc

Merge branch 'main' of github.com:elastic/kibana into opsgenie-connector

7413f2c

Adding more integration tests

dcb1fd9

Updating readme

b6950fc

Starting ui

d019785

jonathan-buttner added backport:skip This commit does not require backporting Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) release_note:feature Makes this part of the condensed release notes v8.6.0 labels Sep 30, 2022

jonathan-buttner added 18 commits October 4, 2022 13:50

Merge branch 'main' of github.com:elastic/kibana into opsgenie-connector

0ba5a6c

Adding hash and alias

0111502

Fixing tests

af4a94a

Switch to platinum for now

3eb263a

Adding server side translations

854492b

Merge branch 'main' of github.com:elastic/kibana into opsgenie-connector

a08975b

Fixing merge issues

9892a2d

Merge branch 'main' of github.com:elastic/kibana into opsgenie-connector

40bbcc4

Fixing file location error

c79afdc

Merge remote-tracking branch 'origin/opsgenie-connector' into opsgeni…

8495a20

…e-ui

Working ui

1822228

Default alias is working

e62858c

Almost working validation fails sometimes

34f37d9

Adding end to end tests

f029784

Merge branch 'main' of github.com:elastic/kibana into opsgenie-ui

7840529

Adding more tests

7c15ded

Adding note and description fields

5bac5de

Merge branch 'main' of github.com:elastic/kibana into opsgenie-ui

686cf97

jonathan-buttner mentioned this pull request Oct 13, 2022

[ResponseOps][Connectors] Opsgenie Connector #142776

Closed

10 tasks

Removing todo

69529d6

jonathan-buttner marked this pull request as ready for review October 13, 2022 19:45

jonathan-buttner requested review from a team as code owners October 13, 2022 19:45

jonathan-buttner requested a review from cnasikas October 13, 2022 19:45

jonathan-buttner commented Oct 13, 2022

View reviewed changes

jonathan-buttner added 2 commits October 17, 2022 09:45

Merge branch 'main' of github.com:elastic/kibana into opsgenie-ui

33ac77c

Fixing test errors

3d97483

cnasikas reviewed Oct 18, 2022

View reviewed changes

cnasikas approved these changes Oct 18, 2022

View reviewed changes

jonathan-buttner added 3 commits October 18, 2022 10:01

Merge branch 'main' of github.com:elastic/kibana into opsgenie-ui

31db0ca

Addressing feedback

f67d32b

Trying to fix test flakiness

ec09bcc

jonathan-buttner enabled auto-merge (squash) October 18, 2022 18:50

jonathan-buttner merged commit e71a522 into elastic:main Oct 18, 2022

jonathan-buttner deleted the opsgenie-ui branch October 18, 2022 20:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ResponseOps][Stack Connectors] Opsgenie connector UI #142411

[ResponseOps][Stack Connectors] Opsgenie connector UI #142411

jonathan-buttner commented Sep 30, 2022 •

edited

Loading

elasticmachine commented Oct 13, 2022

jonathan-buttner Oct 13, 2022

jonathan-buttner Oct 13, 2022

jonathan-buttner Oct 13, 2022

jonathan-buttner Oct 13, 2022

cnasikas Oct 18, 2022

cnasikas Oct 18, 2022

cnasikas Oct 18, 2022

cnasikas Oct 18, 2022 •

edited

Loading

cnasikas Oct 18, 2022

jonathan-buttner Oct 18, 2022

jonathan-buttner Oct 18, 2022

cnasikas Oct 18, 2022

cnasikas Oct 18, 2022

cnasikas Oct 18, 2022

cnasikas Oct 18, 2022

jonathan-buttner Oct 18, 2022

cnasikas left a comment

kibana-ci commented Oct 18, 2022

API count

async chunk count

ESLint disabled line counts

Total ESLint disabled count


		const currentSubAction = useRef<string>(subAction ?? OpsgenieSubActions.CreateAlert);

		const actionOptions = [

-      await find.clickByCssSelector(
-        '[data-test-subj="create-connector-flyout-save-btn"]:not(disabled)'
-      );
-    },
+      const button = await testSubjects.find("create-connector-flyout-save-btn")
+      const isDisabled = await button.isEnabled() // or button.getAttribute('disabled')
+      expect(isDisabled).toBe(false)
+    },

[ResponseOps][Stack Connectors] Opsgenie connector UI #142411

[ResponseOps][Stack Connectors] Opsgenie connector UI #142411

Conversation

jonathan-buttner commented Sep 30, 2022 • edited Loading

Notes

Testing

Examples

Creating alert

Closing alert

Release Notes

elasticmachine commented Oct 13, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cnasikas Oct 18, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cnasikas left a comment

Choose a reason for hiding this comment

kibana-ci commented Oct 18, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

async chunk count

ESLint disabled line counts

Total ESLint disabled count

History

jonathan-buttner commented Sep 30, 2022 •

edited

Loading

cnasikas Oct 18, 2022 •

edited

Loading