Fixing incorrect error that was being displayed on Share to Spaces flyout #142410

kc13greiner · 2022-09-30T20:50:06Z

Summary

An error was being displayed when ES was started without security enabled. since the downstream code was expecting a 404 instead of the bad request error that was being sent on the response.

Steps to reproduce

Start ES with security disabled
~~Login as elastic~~
Create another space
Load any of the sample data sets
Stack Management > Saved Objects > click on the space icon on one of the saved objects
When the flyout opens, there shouldn't be an error

Before:

After:

… is expected downstream

elasticmachine · 2022-09-30T21:51:24Z

Pinging @elastic/kibana-security (Team:Security)

watson · 2022-10-03T10:13:13Z

I just tried to spin up this PR an I'm still getting an error:

construct@[native code]
construct@[native code]
_construct@[...]/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:216838:26
Wrapper@[...]/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:216788:23
construct@[native code]
_createSuperInternal@[...]/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:216527:33
HttpFetchError@[...]/bundles/core/core.entry.js:11852:24
_callee3$@[...]/bundles/core/core.entry.js:11729:92
tryCatch@[...]/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:216932:21
@[...]/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:216912:32
asyncGeneratorStep@[...]/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:77457:24
_next@[...]/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:77479:27
promiseReactionJob@[native code]

I'm not sure if I'm doing it correct however. Your instructions in the PR description says to "Login as elastic", but since security is disabled, the login screen is skipped. I run Elasticsearch with node scripts/es snapshot -E xpack.security.enabled=false.

kc13greiner · 2022-10-03T18:24:31Z

I just tried to spin up this PR an I'm still getting an error:

construct@[native code]
construct@[native code]
_construct@[...]/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:216838:26
Wrapper@[...]/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:216788:23
construct@[native code]
_createSuperInternal@[...]/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:216527:33
HttpFetchError@[...]/bundles/core/core.entry.js:11852:24
_callee3$@[...]/bundles/core/core.entry.js:11729:92
tryCatch@[...]/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:216932:21
@[...]/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:216912:32
asyncGeneratorStep@[...]/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:77457:24
_next@[...]/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:77479:27
promiseReactionJob@[native code]

I'm not sure if I'm doing it correct however. Your instructions in the PR description says to "Login as elastic", but since security is disabled, the login screen is skipped. I run Elasticsearch with node scripts/es snapshot -E xpack.security.enabled=false.

@watson Sorry for the confusion; Ive updated the instructions to better reflect the steps to reproduce and screenshots of the expected results.

As for the error you posted: was that on startup or when trying to reproduce this bug?

jeramysoucy · 2022-10-03T20:19:44Z

I'm not sure if I'm doing it correct however. Your instructions in the PR description says to "Login as elastic", but since security is disabled, the login screen is skipped. I run Elasticsearch with node scripts/es snapshot -E xpack.security.enabled=false.

@watson Sorry for the confusion; Ive updated the instructions to better reflect the steps to reproduce and screenshots of the expected results.

As for the error you posted: was that on startup or when trying to reproduce this bug?

I just pulled this down and everything looks good to the eye, but if you open the browser console or network tab you see a 404 for _share_saved_object_permissions when you click the space icon to open the flyout.

kc13greiner · 2022-10-03T20:57:10Z

I'm not sure if I'm doing it correct however. Your instructions in the PR description says to "Login as elastic", but since security is disabled, the login screen is skipped. I run Elasticsearch with node scripts/es snapshot -E xpack.security.enabled=false.

@watson Sorry for the confusion; Ive updated the instructions to better reflect the steps to reproduce and screenshots of the expected results.
As for the error you posted: was that on startup or when trying to reproduce this bug?

I just pulled this down and everything looks good to the eye, but if you open the browser console or network tab you see a 404 for _share_saved_object_permissions when you click the space icon to open the flyout.

I believe the 404 is the desired outcome (I changed the 4XX error to an anticipated 404 as part of this PR) or at least that's how I interpreted this info in the issue

jeramysoucy · 2022-10-03T22:21:14Z

I believe the 404 is the desired outcome (I changed the 4XX error to an anticipated 404 as part of this PR) or at least that's how I interpreted this info in the issue

Gotcha. Is this an internal-only way of running ES (sec disabled)? If so, I think this is fine.

watson · 2022-10-04T08:53:01Z

As for the error you posted: was that on startup or when trying to reproduce this bug?

That was when I was trying to see if the bug addressed by this PR was fixed. I.e. when I clicked on one of the spaces icons to open the fly-out. Let's sync IRL today to see what's going on

kc13greiner · 2022-10-04T13:34:48Z

I believe the 404 is the desired outcome (I changed the 4XX error to an anticipated 404 as part of this PR) or at least that's how I interpreted this info in the issue

Gotcha. Is this an internal-only way of running ES (sec disabled)? If so, I think this is fine.

Exactly @jeramysoucy - the spaces_manager was looking for a 404 if security is disabled:

.catch((err) => { const isNotFound = err?.body?.statusCode === 404; if (isNotFound) { // security is not enabled return { shareToAllSpaces: true }; }

watson

For some reason I my initial checkout of the PR was still running the old code, hence why I got the same error. Looks fine now 👍

kibana-ci · 2022-10-04T15:55:10Z

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

💚 Build #77295 succeeded 96cf7a9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

… is expected downstream (elastic#142410) (cherry picked from commit 36b2296)

kibanamachine · 2022-10-04T16:32:56Z

💚 All backports created successfully

Status	Branch	Result
✅	8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

… is expected downstream (#142410) (#142638) (cherry picked from commit 36b2296) Co-authored-by: Kurt <[email protected]>

… is expected downstream (elastic#142410)

Checking if security license isEnabled, and if not, throwing 404 that…

96cf7a9

… is expected downstream

kc13greiner linked an issue Sep 30, 2022 that may be closed by this pull request

The Share To Space UI is broken if security is disabled #139629

Closed

kc13greiner marked this pull request as ready for review September 30, 2022 21:51

kc13greiner requested a review from a team as a code owner September 30, 2022 21:51

kc13greiner added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes labels Sep 30, 2022

kc13greiner added v8.5.1 ci:cloud-deploy Create or update a Cloud deployment labels Sep 30, 2022

watson approved these changes Oct 4, 2022

View reviewed changes

Merge branch 'main' into feature/fix_share_to_spaces_error

3b38dcf

kc13greiner merged commit 36b2296 into elastic:main Oct 4, 2022

kc13greiner deleted the feature/fix_share_to_spaces_error branch October 4, 2022 16:29

kibanamachine added the v8.6.0 label Oct 4, 2022

kibanamachine mentioned this pull request Oct 4, 2022

[8.5] Checking if security license isEnabled, and if not, throwing 404 that is expected downstream (#142410) #142638

Merged

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 4, 2022

Checking if security license isEnabled, and if not, throwing 404 that…

b006583

… is expected downstream (elastic#142410) (cherry picked from commit 36b2296)

kibanamachine added a commit that referenced this pull request Oct 4, 2022

Checking if security license isEnabled, and if not, throwing 404 that…

042caf3

… is expected downstream (#142410) (#142638) (cherry picked from commit 36b2296) Co-authored-by: Kurt <[email protected]>

kibanamachine added the v8.5.0 label Oct 4, 2022

WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022

Checking if security license isEnabled, and if not, throwing 404 that…

2c84f62

… is expected downstream (elastic#142410)

WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022

Checking if security license isEnabled, and if not, throwing 404 that…

6d23295

… is expected downstream (elastic#142410)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing incorrect error that was being displayed on Share to Spaces flyout #142410

Fixing incorrect error that was being displayed on Share to Spaces flyout #142410

kc13greiner commented Sep 30, 2022 •

edited by kibanamachine

Loading

elasticmachine commented Sep 30, 2022

watson commented Oct 3, 2022

kc13greiner commented Oct 3, 2022

jeramysoucy commented Oct 3, 2022

kc13greiner commented Oct 3, 2022

jeramysoucy commented Oct 3, 2022

watson commented Oct 4, 2022

kc13greiner commented Oct 4, 2022 •

edited

Loading

watson left a comment

kibana-ci commented Oct 4, 2022 •

edited

Loading

kibanamachine commented Oct 4, 2022

Fixing incorrect error that was being displayed on Share to Spaces flyout #142410

Fixing incorrect error that was being displayed on Share to Spaces flyout #142410

Conversation

kc13greiner commented Sep 30, 2022 • edited by kibanamachine Loading

Summary

Steps to reproduce

elasticmachine commented Sep 30, 2022

watson commented Oct 3, 2022

kc13greiner commented Oct 3, 2022

jeramysoucy commented Oct 3, 2022

kc13greiner commented Oct 3, 2022

jeramysoucy commented Oct 3, 2022

watson commented Oct 4, 2022

kc13greiner commented Oct 4, 2022 • edited Loading

watson left a comment

Choose a reason for hiding this comment

kibana-ci commented Oct 4, 2022 • edited Loading

💚 Build Succeeded

Metrics [docs]

History

kibanamachine commented Oct 4, 2022

💚 All backports created successfully

Questions ?

kc13greiner commented Sep 30, 2022 •

edited by kibanamachine

Loading

kc13greiner commented Oct 4, 2022 •

edited

Loading

kibana-ci commented Oct 4, 2022 •

edited

Loading