Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profiling] Show Top 1000 functions #142391

Merged
merged 3 commits into from
Oct 4, 2022
Merged

[Profiling] Show Top 1000 functions #142391

merged 3 commits into from
Oct 4, 2022

Conversation

rockdaboot
Copy link
Contributor

@rockdaboot rockdaboot commented Sep 30, 2022 •
edited by kibanamachine
Loading

We discussed a while ago that we drop the input field for the number of functions and instead show the Top 1000 functions.

Fixes https://github.com/elastic/prodfiler/issues/2680

@rockdaboot rockdaboot added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v8.5.0 labels Sep 30, 2022
@rockdaboot rockdaboot requested a review from a team as a code owner September 30, 2022 16:53
@rockdaboot
Copy link
Contributor Author

@elasticmachine merge upstream

@rockdaboot rockdaboot enabled auto-merge (squash) October 4, 2022 10:27
@rockdaboot
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #33 / lens app - group 2 lens dashboard tests should be able to add filters by clicking in pie chart

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 238.0KB 238.0KB -13.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rockdaboot rockdaboot merged commit 8be7668 into elastic:main Oct 4, 2022
@kibanamachine kibanamachine mentioned this pull request Oct 4, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 4, 2022
@rockdaboot
[Profiling] Show Top 1000 functions (elastic#142391)
a53b360 
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 8be7668)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 4, 2022
@kibanamachine @rockdaboot
[Profiling] Show Top 1000 functions (#142391) (#142590)
9c10e55 
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 8be7668)

Co-authored-by: Tim Rühsen <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@rockdaboot @kibanamachine @WafaaNasr
[Profiling] Show Top 1000 functions (elastic#142391)
58fd59b 
Co-authored-by: Kibana Machine <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@rockdaboot @kibanamachine @WafaaNasr
[Profiling] Show Top 1000 functions (elastic#142391)
f1658f1 
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rockdaboot @kibana-ci @kibanamachine @dgieselaar