[ML] Api tests for ml/modules/jobs_exist/{moduleId} #142378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
non-issue
|
Pinging @elastic/ml-ui (:ml) |
jgowdyelastic
commented
Sep 30, 2022
| @@ -54,27 +54,40 @@ export function MachineLearningTestResourcesProvider( | |||
| await kibanaServer.uiSettings.unset('hideAnnouncements'); | |||
| }, | |||
|
|
|||
| async savedObjectExistsById(id: string, objectType: SavedObjectType): Promise<boolean> { | |||
| const response = await supertest.get(`/api/saved_objects/${objectType}/${id}`); | |||
| async savedObjectExistsById( | |||
There was a problem hiding this comment.
All the changes in this file are to pass the space name around for the functions used by this test
pheyos
approved these changes
Sep 30, 2022
|
retest |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 3, 2022
* [ML] Api tests for ml/modules/jobs_exist/{moduleId}
* fixing title
* fixing delete index pattern function
(cherry picked from commit 656a48f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
19 tasks
kibanamachine
added a commit
that referenced
this pull request
Oct 3, 2022
* [ML] Api tests for ml/modules/jobs_exist/{moduleId}
* fixing title
* fixing delete index pattern function
(cherry picked from commit 656a48f)
Co-authored-by: James Gowdy <[email protected]>
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 11, 2022
* [ML] Api tests for ml/modules/jobs_exist/{moduleId}
* fixing title
* fixing delete index pattern function
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 14, 2022
* [ML] Api tests for ml/modules/jobs_exist/{moduleId}
* fixing title
* fixing delete index pattern function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates modules and then calls the jobs exists endpoint to see if the jobs have been created.
Tries with and without a prefix, also tries when installing module into a different space.
Part of #137573