Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Profiling] Avoid line-break of samples #142322

Merged
merged 2 commits into from
Oct 6, 2022

Conversation

rockdaboot
Copy link
Contributor

@rockdaboot rockdaboot commented Sep 30, 2022

Avoid line breaking of samples if the number is even 9 digits long.

Fixes https://github.com/elastic/prodfiler/issues/2684

@rockdaboot rockdaboot added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v8.5.0 labels Sep 30, 2022
@rockdaboot rockdaboot requested a review from a team as a code owner September 30, 2022 10:51
@rockdaboot rockdaboot force-pushed the rockdaboot/fix-samples-width branch from 7573558 to a81ee41 Compare October 6, 2022 13:56
@rockdaboot rockdaboot force-pushed the rockdaboot/fix-samples-width branch from a81ee41 to 4ec5dc2 Compare October 6, 2022 14:07
@rockdaboot
Copy link
Contributor Author

@elasticmachine merge upstream

@rockdaboot rockdaboot enabled auto-merge (squash) October 6, 2022 15:27
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 235.9KB 236.0KB +100.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rockdaboot rockdaboot merged commit ba306be into elastic:main Oct 6, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 6, 2022
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit ba306be)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 6, 2022
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit ba306be)

Co-authored-by: Tim Rühsen <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v8.5.0 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants