Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.5] [Synthetics] enable/disable - prevent incorrect keys from being added to the monitor saved object (#140553) #142238

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.5:

Questions ?

Please refer to the Backport tool documentation

… to the monitor saved object (elastic#140553)

* synthetics - enable/disable - prevent incorrect keys from being added to the monitor saved object

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* adjust types

* add exact typing

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* adjust test

* use exact types

* use exact types for editing

* adjust types

* adjust tests

* adjust types

* Update x-pack/test/api_integration/apis/uptime/rest/add_monitor.ts

* adjust normalizers

* Update x-pack/plugins/synthetics/common/runtime_types/monitor_management/monitor_types.ts

* Update x-pack/plugins/synthetics/server/routes/monitor_cruds/add_monitor.ts

* adjust types

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* adjust jest tests

* adjust types

* adjust api_integration tests

* update tests

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 27916d3)
@kibanamachine kibanamachine requested a review from a team as a code owner September 29, 2022 15:29
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Sep 29, 2022
@kibanamachine kibanamachine enabled auto-merge (squash) September 29, 2022 15:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1023.3KB 1023.6KB +297.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dominiqueclarke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants