[Observability] Fix flaky test #142210
Merged
[Observability] Fix flaky test #142210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
added
release_note:skip
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
maryam-saeidi
approved these changes
Sep 30, 2022
| search: `?rangeFrom=${rangeFrom}&rangeTo=${rangeTo}`, | ||
| }); | ||
|
|
||
| await PageObjects.header.waitUntilLoadingHasFinished(); |
There was a problem hiding this comment.
Shall we move waitUntilLoadingHasFinished inside navigateToApp?
| @@ -48,16 +42,28 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { | |||
| await esArchiver.unload( | |||
| Path.join('x-pack/test/apm_api_integration/common/fixtures/es_archiver', 'rum_8.0.0') | |||
| ); | |||
| await esArchiver.unload( | |||
There was a problem hiding this comment.
Just curious: if in loadIfNeeded the archive is not loaded, how does unload work in that case?
maryam-saeidi
added
the
failed-test
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 11, 2022
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #142210
Flaky test run https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1335