Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Make "Run diagnostics" be a clickable link #142174

Merged
merged 3 commits into from
Oct 5, 2022

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Sep 29, 2022

Summary

Closes #121056

Screen Shot 2022-09-28 at 5 32 04 PM

Testing

I used MacOS for development, which can not lack system dependencies. To force an error that would show a documentation link, I hacked the diagnostics route handler with this patch:

diff --git a/x-pack/plugins/reporting/server/routes/diagnostic/browser.ts b/x-pack/plugins/reporting/server/routes/diagnostic/browser.ts
index 53046a8680c..fd5364b1343 100644
--- a/x-pack/plugins/reporting/server/routes/diagnostic/browser.ts
+++ b/x-pack/plugins/reporting/server/routes/diagnostic/browser.ts
@@ -61,7 +61,7 @@ export const registerDiagnoseBrowser = (reporting: ReportingCore, logger: Logger
             helpTexts.push(helpText);
           }
           return helpTexts;
-        }, []);
+        }, [logsToHelpMap['error while loading shared libraries']]);

         const response: DiagnosticResponse = {
           success: boundSuccessfully && !help.length,

@tsullivan tsullivan requested review from a team as code owners September 29, 2022 00:31
@tsullivan tsullivan added the release_note:skip Skip the PR/issue when compiling release notes label Sep 29, 2022
@tsullivan tsullivan marked this pull request as draft September 29, 2022 01:13
@tsullivan tsullivan marked this pull request as ready for review September 29, 2022 03:52
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
reporting 58.6KB 58.7KB +40.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit ba52231 into elastic:main Oct 5, 2022
@tsullivan tsullivan deleted the reporting/diagnostic-doc-url branch October 5, 2022 16:39
@kibanamachine kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Oct 5, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Reporting] Run diagnostics should provide a clickable link
4 participants