Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Update copy for landing page #141979

Merged
merged 3 commits into from
Oct 4, 2022
Merged

[Enterprise Search] Update copy for landing page #141979

merged 3 commits into from
Oct 4, 2022

Conversation

byronhulcher
Copy link
Contributor

@byronhulcher byronhulcher commented Sep 27, 2022 •
edited by kibanamachine
Loading

Summary

Requested by @leemthompo

Checklist

@byronhulcher byronhulcher added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Sep 27, 2022
@byronhulcher byronhulcher self-assigned this Sep 27, 2022
@byronhulcher byronhulcher requested a review from a team September 27, 2022 16:45
leemthompo
leemthompo approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @byronhulcher 💟

@byronhulcher
Copy link
Contributor Author

@elasticmachine merge upstream

@byronhulcher byronhulcher enabled auto-merge (squash) October 4, 2022 15:01
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.7MB 1.7MB -10.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @byronhulcher

@byronhulcher byronhulcher merged commit 1c25d93 into elastic:main Oct 4, 2022
@kibanamachine kibanamachine mentioned this pull request Oct 4, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 4, 2022
@byronhulcher
[Enterprise Search] Update copy for landing page (elastic#141979)
86cfda9 
(cherry picked from commit 1c25d93)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 4, 2022
@kibanamachine @byronhulcher
[Enterprise Search] Update copy for landing page (#141979) (#142632)
92ea4f2 
(cherry picked from commit 1c25d93)

Co-authored-by: Byron Hulcher <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@byronhulcher @WafaaNasr
[Enterprise Search] Update copy for landing page (elastic#141979)
c611716
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@byronhulcher @WafaaNasr
[Enterprise Search] Update copy for landing page (elastic#141979)
482d91c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemthompo leemthompo leemthompo approved these changes

@efegurkan efegurkan efegurkan approved these changes

Assignees

@byronhulcher byronhulcher

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@byronhulcher @kibana-ci @kibanamachine @efegurkan @leemthompo