-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci/cloud-deploy] Remove CI success requirement #141965
Conversation
This removes the success requirement in the cloud deployment step for pull requests. Creating a cloud deployment from a pull request is optional and not providing test coverage. Failures are typically upstream and not something that can be fixed from the Kibana repository.
Pinging @elastic/kibana-operations (Team:Operations) |
Okay that worked - misread the checks and thought it was related, but it's just missing a code owner review. The |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is great and needed, but we should follow-up with ensuring we communicate when this happens in an annotation and the CI comment on the PR.
This removes the success requirement in the cloud deployment step for pull requests. Creating a cloud deployment from a pull request is optional and not providing test coverage. Failures are typically upstream and not something that can be fixed from the Kibana repository.
This removes the success requirement in the cloud deployment step for pull requests. Creating a cloud deployment from a pull request is optional and not providing test coverage. Failures are typically upstream and not something that can be fixed from the Kibana repository.
This removes the success requirement in the cloud deployment step for pull requests.
Creating a cloud deployment from a pull request is optional and not providing test coverage. Failures are typically upstream and not something that can be fixed from the Kibana repository.