Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci/cloud-deploy] Remove CI success requirement #141965

Merged
merged 5 commits into from
Oct 5, 2022

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Sep 27, 2022

This removes the success requirement in the cloud deployment step for pull requests.

Creating a cloud deployment from a pull request is optional and not providing test coverage. Failures are typically upstream and not something that can be fixed from the Kibana repository.

This removes the success requirement in the cloud deployment step for
pull requests.

Creating a cloud deployment from a pull request is optional and not
providing test coverage.  Failures are typically upstream and not
something that can be fixed from the Kibana repository.
@jbudz jbudz added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes ci:cloud-deploy Create or update a Cloud deployment labels Sep 27, 2022
@jbudz jbudz marked this pull request as ready for review September 27, 2022 16:54
@jbudz jbudz requested a review from a team as a code owner September 27, 2022 16:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz jbudz marked this pull request as draft September 27, 2022 17:52
@jbudz jbudz marked this pull request as ready for review September 28, 2022 15:36
@jbudz
Copy link
Member Author

jbudz commented Sep 28, 2022

Okay that worked - misread the checks and thought it was related, but it's just missing a code owner review. The Build Failed comment needs to be fixed in a different repo.

@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 3, 2022

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great and needed, but we should follow-up with ensuring we communicate when this happens in an annotation and the CI comment on the PR.

@jbudz jbudz merged commit f1f2107 into elastic:main Oct 5, 2022
@kibanamachine kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Oct 5, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
This removes the success requirement in the cloud deployment step for
pull requests.

Creating a cloud deployment from a pull request is optional and not
providing test coverage.  Failures are typically upstream and not
something that can be fixed from the Kibana repository.
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
This removes the success requirement in the cloud deployment step for
pull requests.

Creating a cloud deployment from a pull request is optional and not
providing test coverage.  Failures are typically upstream and not
something that can be fixed from the Kibana repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants