[Connectors] Split ServiceNow connector type #141961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymao1
force-pushed
the
connector-types-split-servicenow
branch
from
ca41911 to
b556b11
Compare
ymao1
changed the title
ymao1
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
…or-types-split-servicenow
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
pmuellr
approved these changes
Oct 4, 2022
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @ymao1 |
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 11, 2022
* Splitting public servicenow files * Splitting server servicenow files * Fixing checks * Fixing checks * Moving xmatters to stack Co-authored-by: Kibana Machine <[email protected]>
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 14, 2022
* Splitting public servicenow files * Splitting server servicenow files * Fixing checks * Fixing checks * Moving xmatters to stack Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #90931
Summary
The ServiceNow connector type is actually 3 different connector types: ServiceNow ITOM, ServiceNow ITSM and ServiceNow SecOps. Cases should own ITSM and SecOps and E&C should own ITOM, so this PR tries to decouple the UI and server code for these connectors and move them to the appropriate folder.
Also moved Xmatters to
stackfolder because I incorrectly put it incasesin the initial PR.To Verify
You should be able to create all three types of ServiceNow connectors and successfully test them in the test tab.