Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Connectors] Split functional tests by connector type #141956

Merged
merged 13 commits into from
Oct 5, 2022
Merged

[Connectors] Split functional tests by connector type #141956

merged 13 commits into from
Oct 5, 2022

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Sep 27, 2022

Towards #90931

@ymao1 ymao1 self-assigned this Sep 27, 2022
@ymao1 ymao1 added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework v8.6.0 release_note:skip Skip the PR/issue when compiling release notes labels Sep 27, 2022
@ymao1 ymao1 marked this pull request as ready for review September 27, 2022 16:01
@ymao1 ymao1 requested a review from a team as a code owner September 27, 2022 16:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@ymao1
Copy link
Contributor Author

ymao1 commented Sep 28, 2022

@elasticmachine merge upstream

@ymao1
Copy link
Contributor Author

ymao1 commented Sep 28, 2022

@elasticmachine merge upstream

doakalexi
doakalexi approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@doakalexi doakalexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ymao1
Copy link
Contributor Author

ymao1 commented Oct 3, 2022

@elasticmachine merge upstream

@ymao1
Copy link
Contributor Author

ymao1 commented Oct 5, 2022

@elasticmachine merge upstream

1 similar comment
@ymao1
Copy link
Contributor Author

ymao1 commented Oct 5, 2022

@elasticmachine merge upstream

ersin-erdal
ersin-erdal approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@ersin-erdal ersin-erdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1
Copy link
Contributor Author

ymao1 commented Oct 5, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

@ymao1 ymao1 merged commit f80fd78 into elastic:main Oct 5, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 5, 2022
@ymao1 ymao1 deleted the connector-types-plugin-split-tests branch October 5, 2022 17:09
@ymao1 ymao1 mentioned this pull request Oct 5, 2022
Closed
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@ymao1 @kibanamachine @WafaaNasr
[Connectors] Split functional tests by connector type (elastic#141956)
f717d03 
* Renaming folder

* Renaming folder

* Moving xmatters to stack

* Moving xmatters to stack

Co-authored-by: Kibana Machine <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@ymao1 @kibanamachine @WafaaNasr
[Connectors] Split functional tests by connector type (elastic#141956)
55ec1c6 
* Renaming folder

* Renaming folder

* Moving xmatters to stack

* Moving xmatters to stack

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doakalexi doakalexi doakalexi approved these changes

@ersin-erdal ersin-erdal ersin-erdal approved these changes

Assignees

@ymao1 ymao1

Labels
backport:skip This commit does not require backporting Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.6.0
Projects
No open projects
AppEx: ResponseOps - Execution & Connectors
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ymao1 @elasticmachine @kibana-ci @ersin-erdal @doakalexi @kibanamachine