Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Response Ops] [Alerting] Rules and Connectors: Current page in breadcrumbs shows as link #141838

Merged
merged 4 commits into from
Sep 29, 2022
Merged

[Response Ops] [Alerting] Rules and Connectors: Current page in breadcrumbs shows as link #141838

merged 4 commits into from
Sep 29, 2022

Conversation

doakalexi
Copy link
Contributor

@doakalexi doakalexi commented Sep 26, 2022 •
edited
Loading

Resolves #136969

Summary

The breadcrumbs in Rules and Connectors show the last item (current page) as a link, this pr allows you to conditionally send back the href for the bread crumb.

Checklist

To Verify

  • Navigate to the Rules and Connectors page
  • Click on the different tabs, Rules, Connectors, and Logs
  • Verify that The last item in our breadcrumbs should show the current page and be styled differently from the previous / parent pages. It should not be clickable compared to the parent pages, which are clickable (the reason for the difference in styling).
  • Click into the rules details and verify the same as above

@doakalexi doakalexi changed the title Updating breadcrumb function for alerting [Response Ops] [Alerting] Rules and Connectors: Current page in breadcrumbs shows as link Sep 26, 2022
@doakalexi doakalexi added release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Sep 26, 2022
@doakalexi doakalexi marked this pull request as ready for review September 26, 2022 19:35
@doakalexi doakalexi requested a review from a team as a code owner September 26, 2022 19:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

ymao1
ymao1 approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Verified works as expected.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 668.2KB 668.1KB -112.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ersin-erdal
ersin-erdal approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@ersin-erdal ersin-erdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doakalexi doakalexi merged commit 7c9875c into elastic:main Sep 29, 2022
@kibanamachine kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Sep 29, 2022
@doakalexi doakalexi deleted the alerting/disable-breadcrumbs branch December 6, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ersin-erdal ersin-erdal ersin-erdal approved these changes

@ymao1 ymao1 ymao1 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Response Ops] Rules and Connectors: Current page in breadcrumbs shows as link
6 participants
@doakalexi @elasticmachine @kibana-ci @ymao1 @ersin-erdal @kibanamachine