Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Files] Fix flaky file creation and deletion tests #141753

Merged
merged 14 commits into from
Oct 6, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,7 @@ import { createEsFileClient } from '../create_es_file_client';
import { FileClient } from '../types';
import { FileMetadata } from '../../../common';

/**
* This file client is using Elasticsearch interfaces directly to manage files.
*/
// FLAKY: https://github.com/elastic/kibana/issues/139565
describe.skip('ES-index-backed file client', () => {
describe('ES-index-backed file client', () => {
let esClient: TestEnvironmentUtils['esClient'];
let fileClient: FileClient;
let testHarness: TestEnvironmentUtils;
Expand Down Expand Up @@ -197,6 +193,9 @@ describe.skip('ES-index-backed file client', () => {
})
);

await Promise.all([fileClient.delete({ id: id1 }), fileClient.delete({ id: id2 })]);
await Promise.all([
fileClient.delete({ id: id1, hasContent: false }),
fileClient.delete({ id: id2, hasContent: false }),
]);
});
});