Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Explain Log Rate Spikes: Reduce data view font size. #141351

Closed
wants to merge 1 commit into from
Closed

[ML] Explain Log Rate Spikes: Reduce data view font size. #141351

wants to merge 1 commit into from

Conversation

walterra
Copy link
Contributor

Summary

Part of #138117.

Reduces the data view h2 font size from s to xs.

Before:

image

After:

image

Checklist

@walterra walterra added :ml release_note:skip Skip the PR/issue when compiling release notes v8.5.0 Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis v8.6.0 labels Sep 22, 2022
@walterra walterra self-assigned this Sep 22, 2022
@walterra walterra requested a review from a team as a code owner September 22, 2022 07:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra mentioned this pull request Sep 22, 2022
Closed
9 tasks
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 759.4KB 759.4KB +1.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

alvarezmelissa87
alvarezmelissa87 approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@qn895
Copy link
Member

qn895 commented Sep 23, 2022

LGTM

@walterra walterra closed this Sep 26, 2022
@walterra walterra deleted the ml-aiops-data-view-font-size branch September 26, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@qn895 qn895 qn895 approved these changes

@peteharverson peteharverson Awaiting requested review from peteharverson

Assignees

@walterra walterra

Labels
Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:skip Skip the PR/issue when compiling release notes v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@walterra @elasticmachine @kibana-ci @qn895 @alvarezmelissa87