[APM] Agent configuration - EuiMarkdownFormat when rendering setting description #141086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yngrdyn
added
release_note:skip
|
Pinging @elastic/apm-ui (Team:APM) |
kpatticha
approved these changes
Sep 20, 2022
kpatticha
reviewed
Sep 20, 2022
| @@ -163,7 +164,7 @@ export function SettingFormRow({ | |||
| } | |||
| description={ | |||
| <> | |||
| {setting.description} | |||
| <ReactMarkdown>{setting.description}</ReactMarkdown> | |||
There was a problem hiding this comment.
FYI: Eui has a formatter that renders the markdown and it seems to be used
There was a problem hiding this comment.
ohhh! I liked that one better.
should we use that one instead?
There was a problem hiding this comment.
it looks nice 🤩 !
EuiMarkdownFormat is labeled as beta but it was released on 28.0.0 - more than 2 years ago, so I think we won't have any issue.
yngrdyn
force-pushed
the
agent_remote_configuration_inline_code_examples
branch
from
b5c0a7a to
0faffbe
Compare
yngrdyn
changed the title
…-ref HEAD~1..HEAD --fix'
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes 61285
EuiMarkdownFormatcomponent to render setting description.Before this change
After this change
