Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing esArchiver in favor of testDataLoader for bulk_get Saved Objects integration tests #140998

Merged
merged 13 commits into from
Oct 4, 2022
Merged

Removing esArchiver in favor of testDataLoader for bulk_get Saved Objects integration tests #140998

merged 13 commits into from
Oct 4, 2022

Conversation

kc13greiner
Copy link
Contributor

@kc13greiner kc13greiner commented Sep 19, 2022 •
edited by kibanamachine
Loading

Summary

Removing esArchiver in the bulk_get api integration tests

Flaky Test Runner

security_and_spaces/config_basic.ts x 50 ✅
security_and_spaces/config_trial.ts x 50 ✅
spaces_only/config.ts x 50 ✅

@kc13greiner kc13greiner linked an issue Sep 19, 2022 that may be closed by this pull request
Failing test: X-Pack Saved Object API Integration Tests -- security_and_spaces.x-pack/test/saved_object_api_integration/security_and_spaces/apis/bulk_get·ts - saved objects security and spaces enabled _bulk_get user with no access within the default space "before all" hook for "should return 403 forbidden [isolatedtype/defaultspace-isolatedtype-id]" #138352
Closed
@kc13greiner kc13greiner added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes v8.5.0 labels Sep 19, 2022
@kc13greiner kc13greiner changed the title Removing esArchiver in favor of testDataLoader Removing esArchiver in favor of testDataLoader for bulk_get Saved Objects integration tests Sep 19, 2022
@kc13greiner kc13greiner added the backport:all-open Backport to all branches that could still receive a release label Sep 23, 2022
@kc13greiner kc13greiner marked this pull request as ready for review September 23, 2022 13:44
@kc13greiner kc13greiner requested a review from a team as a code owner September 23, 2022 13:44
@kc13greiner kc13greiner requested a review from watson September 30, 2022 21:50
watson
watson reviewed Oct 3, 2022
View reviewed changes
Copy link
Contributor

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Just one question, which might just be a misunderstanding on my part

x-pack/test/saved_object_api_integration/common/suites/bulk_get.ts Outdated Show resolved Hide resolved
@kc13greiner kc13greiner requested a review from watson October 3, 2022 18:25
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #40 / analytics instrumented events from the browser Loaded Dashboard full loaded dashboard should emit the "Loaded Dashboard" event when done loading complex dashboard

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kc13greiner kc13greiner merged commit 6875d18 into elastic:main Oct 4, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 4, 2022
@kc13greiner
Removing esArchiver in favor of testDataLoader for bulk_get Saved O…
0822027 
…bjects integration tests (elastic#140998)

* Removing esArchiver in favor of testDataLoader

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Adding test data for loader

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Adding generic TestDataLoader

* Importing just the type per PR feedback

* Changing testDataLoader function names to be more descriptive

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Larry Gregory <[email protected]>
Co-authored-by: Thomas Watson <[email protected]>
(cherry picked from commit 6875d18)
This was referenced Oct 4, 2022
Closed
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 4, 2022
@kc13greiner
Removing esArchiver in favor of testDataLoader for bulk_get Saved O…
0588460 
…bjects integration tests (elastic#140998)

* Removing esArchiver in favor of testDataLoader

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Adding test data for loader

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Adding generic TestDataLoader

* Importing just the type per PR feedback

* Changing testDataLoader function names to be more descriptive

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Larry Gregory <[email protected]>
Co-authored-by: Thomas Watson <[email protected]>
(cherry picked from commit 6875d18)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 7.17
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 4, 2022
@kibanamachine @kc13greiner
Removing esArchiver in favor of testDataLoader for bulk_get Saved O…
95e32aa 
…bjects integration tests (#140998) (#142600)

* Removing esArchiver in favor of testDataLoader

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Adding test data for loader

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Adding generic TestDataLoader

* Importing just the type per PR feedback

* Changing testDataLoader function names to be more descriptive

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Larry Gregory <[email protected]>
Co-authored-by: Thomas Watson <[email protected]>
(cherry picked from commit 6875d18)

Co-authored-by: Kurt <[email protected]>
kc13greiner added a commit to kc13greiner/kibana that referenced this pull request Oct 4, 2022
@kc13greiner @kibanamachine @legrego
Removing esArchiver in favor of testDataLoader for bulk_get Saved O…
4f130ad 
…bjects integration tests (elastic#140998)

* Removing esArchiver in favor of testDataLoader

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Adding test data for loader

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Adding generic TestDataLoader

* Importing just the type per PR feedback

* Changing testDataLoader function names to be more descriptive

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Larry Gregory <[email protected]>
Co-authored-by: Thomas Watson <[email protected]>
@kc13greiner kc13greiner mentioned this pull request Oct 4, 2022
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 5, 2022
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

3 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@legrego legrego mentioned this pull request Oct 10, 2022
Closed
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@kc13greiner @kibanamachine
@legrego @WafaaNasr
Removing esArchiver in favor of testDataLoader for bulk_get Saved O…
caa43c4 
…bjects integration tests (elastic#140998)

* Removing esArchiver in favor of testDataLoader

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Adding test data for loader

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Adding generic TestDataLoader

* Importing just the type per PR feedback

* Changing testDataLoader function names to be more descriptive

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Larry Gregory <[email protected]>
Co-authored-by: Thomas Watson <[email protected]>
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kc13greiner added a commit that referenced this pull request Oct 13, 2022
@kc13greiner @kibanamachine @legrego
[7.17] Removing esArchiver in favor of testDataLoader for bulk_get …
d60b53b 
…Saved Objects integration tests (#140998) (#142670)

* Removing esArchiver in favor of testDataLoader for `bulk_get` Saved Objects integration tests (#140998)

* Removing esArchiver in favor of testDataLoader

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Adding test data for loader

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Adding generic TestDataLoader

* Importing just the type per PR feedback

* Changing testDataLoader function names to be more descriptive

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Larry Gregory <[email protected]>
Co-authored-by: Thomas Watson <[email protected]>

* Changing SecurityOnly to use the context when calling the bulkGet tests

* Updating versions of saved objects

* Missing SO for the SecurityOnly tests

* Remove prefix from ID

* Permitting SecurityOnly tests to use esArchiver because objects cant be created with namespaces and spaces disabled through kibana

* Moving async calls out of map and awaiting

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Larry Gregory <[email protected]>
Co-authored-by: Thomas Watson <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 13, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@kc13greiner @kibanamachine
@legrego @WafaaNasr
Removing esArchiver in favor of testDataLoader for bulk_get Saved O…
527eb5c 
…bjects integration tests (elastic#140998)

* Removing esArchiver in favor of testDataLoader

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Adding test data for loader

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Adding generic TestDataLoader

* Importing just the type per PR feedback

* Changing testDataLoader function names to be more descriptive

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Larry Gregory <[email protected]>
Co-authored-by: Thomas Watson <[email protected]>
@jeramysoucy jeramysoucy mentioned this pull request Jul 7, 2023
Open
@kc13greiner kc13greiner deleted the feature/remove_esArchiver_from_saveObject_integration_tests branch January 26, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watson watson watson approved these changes

Assignees
No one assigned
Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
5 participants
@kc13greiner @kibana-ci @kibanamachine @watson @legrego