Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ILM] Hide readonly action if downsample enabled #140804

Merged
merged 5 commits into from
Sep 20, 2022
Merged

[ILM] Hide readonly action if downsample enabled #140804

merged 5 commits into from
Sep 20, 2022

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Sep 15, 2022

Summary

fix #140515

@Dosant Dosant added enhancement New value added to drive a business result Feature:ILM release_note:skip Skip the PR/issue when compiling release notes v8.5.0 labels Sep 15, 2022
@Dosant Dosant marked this pull request as ready for review September 15, 2022 14:17
@Dosant Dosant requested a review from a team as a code owner September 15, 2022 14:17
@Dosant Dosant requested review from cqliu1, ghudgins, alisonelizabeth and yuliacech and removed request for cqliu1 September 15, 2022 14:17
@Dosant
Copy link
Contributor Author

Dosant commented Sep 19, 2022

@elasticmachine merge upstream

alisonelizabeth
alisonelizabeth reviewed Sep 19, 2022
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @Dosant! I tested locally and works as expected. I left a few comments in the tests. Would you mind taking a look? I think there might be some room to improve coverage. Thanks!

@Dosant
Copy link
Contributor Author

Dosant commented Sep 19, 2022

@alisonelizabeth, improved the coverage as you suggested 👍

alisonelizabeth
alisonelizabeth approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest LGTM. Thanks for improving the test coverage!

@Dosant
Copy link
Contributor Author

Dosant commented Sep 20, 2022

@elasticmachine merge upstream

@Dosant Dosant enabled auto-merge (squash) September 20, 2022 13:22
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #29 / dashboard app - group 1 dashboard embeddable rendering data rendered correctly when dashboard is hard refreshed

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexLifecycleManagement 158.7KB 159.1KB +447.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit 5623e0e into elastic:main Sep 20, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 20, 2022
@spalger spalger mentioned this pull request Sep 23, 2022
Closed
@Dosant Dosant mentioned this pull request Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

@ghudgins ghudgins Awaiting requested review from ghudgins

@yuliacech yuliacech Awaiting requested review from yuliacech

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting enhancement New value added to drive a business result Feature:ILM release_note:skip Skip the PR/issue when compiling release notes v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ILM] Hide readonly action if downsample enabled
4 participants
@Dosant @kibana-ci @alisonelizabeth @kibanamachine