-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra Monitoring UI] add tech preview for hosts view #140766
[Infra Monitoring UI] add tech preview for hosts view #140766
Conversation
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
I only got "stuck" on the fact that I had to reload the page for the side nav to update, I wonder if we can somehow make it update in response to the setting changing?
I think it should be possible to get an observable from uiSettings?
@miltonhultgren I think you're right. Looks like a few other plugins do it like this:
Haven't tried this to see if it will work without having to reload the page but it might work. |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Page load bundle
History
To update your PR or re-run it, just comment with: |
Closes #139589
Adds option in Stack Management > Advanced Settings to preview the Infrastructure Hosts View:
If enabled, should appear in the navigation under Infrastructure:
If enabled, should appear in search results: