Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra Monitoring UI] add tech preview for hosts view #140766

Merged
merged 6 commits into from
Sep 19, 2022

Conversation

neptunian
Copy link
Contributor

@neptunian neptunian commented Sep 14, 2022

Closes #139589

Adds option in Stack Management > Advanced Settings to preview the Infrastructure Hosts View:

Screen Shot 2022-09-14 at 3 08 09 PM

If enabled, should appear in the navigation under Infrastructure:
Screen Shot 2022-09-14 at 3 09 03 PM

If enabled, should appear in search results:
Screen Shot 2022-09-14 at 3 09 14 PM

@neptunian neptunian added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes labels Sep 14, 2022
@neptunian neptunian changed the title add tech preview for hosts view [Infra Monitoring UI] add tech preview for hosts view Sep 14, 2022
@neptunian neptunian marked this pull request as ready for review September 14, 2022 21:10
@neptunian neptunian requested review from a team as code owners September 14, 2022 21:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

Copy link
Contributor

@miltonhultgren miltonhultgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

I only got "stuck" on the fact that I had to reload the page for the side nav to update, I wonder if we can somehow make it update in response to the setting changing?

I think it should be possible to get an observable from uiSettings?

@smith
Copy link
Contributor

smith commented Sep 15, 2022

I think it should be possible to get an observable from uiSettings?

@miltonhultgren I think you're right. Looks like a few other plugins do it like this:

import useObservable from 'react-use/lib/useObservable';
const isHostsViewEnabled = useObservable<boolean>(core.uiSettings.get$(enableInfrastructureHostsView));

Haven't tried this to see if it will work without having to reload the page but it might work.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 497 505 +8

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 84.5KB 84.6KB +150.0B
observability 64.9KB 65.1KB +210.0B
total +360.0B
Unknown metric groups

API count

id before after diff
observability 501 509 +8

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Epic: Host Observability release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Infrastructure UI] put hosts view behind technical preview
7 participants