Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds new contextual attributes to Infrastructure - Inventory Rule #140598
Adds new contextual attributes to Infrastructure - Inventory Rule #140598
Changes from all commits
730cd37
510589b
6370e18
6febb7a
e73adf6
8bff527
270e7b7
28ef8ac
f9f72a8
8b639f3
9a61c03
61f9db1
9c9d01d
2374b89
61fb092
2b02c20
9c7ae7f
c5f7cb6
69f92e7
5223d55
b01f85f
a5df51d
32a03f3
0e5fa80
cb12847
920aa98
f98d7f3
6b616f7
a1d66dd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❔ For curiosity: why are we excluding some of them? How did you come up with that list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The excluded fields are "metric" fields like
host.cpu.usage
orhost.network.ingress.bytes
. They wouldn't be very useful as search fields.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simianhacker, in which case do we need to perform a search?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly for strings like
host.name
orhost.os.architecture
, any context that might be useful for search. A good rule of thumb would be "exclude anything that changes from event to event and include anything that is common across all events for an entity".