Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Fix monitor summary page layout #140492

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Sep 12, 2022

Summary

After:

image

Before

image

@shahzad31 shahzad31 requested a review from a team as a code owner September 12, 2022 12:13
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Sep 12, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 changed the title fix page layout [Synthetics] Fix monitor summary page layout Sep 12, 2022
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.5.0 labels Sep 12, 2022
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 984.7KB 984.7KB +16.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31 shahzad31 merged commit fd424e6 into elastic:main Sep 12, 2022
@shahzad31 shahzad31 deleted the fix-layout branch September 12, 2022 13:57
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 12, 2022
@lucasfcosta lucasfcosta self-assigned this Sep 28, 2022
@lucasfcosta
Copy link
Contributor

lucasfcosta commented Sep 28, 2022

Just post-FF tested this and the layout LGTM for browser monitors, here's what I did:

  1. Create a new deployment on Cloud using the 8.5.0-SNAPSHOT tag on CFT
  2. Enabled the new Synthetics UI
  3. Created a monitor
  4. Accessed its details page

Screenshot 2022-09-28 at 14 58 19

I also created an HTTP monitor just in case and checked its layout too, but there was one problem: some of the components never finished loading. Those were the components with details about the run history.

Screenshot 2022-09-28 at 14 59 25

I created a separate issue for that here: #142113 (@paulb-elastic I also moved that to the "primary" column because it seemed significant enough, but lmk if we actually intend to fix that only in 8.6).

@paulb-elastic
Copy link
Contributor

@lucasfcosta thanks for raising. I've put #142113 in the 8.5 column for now, although we'll need to get other 8.5 things finished up first, as the UI won't be for users to use in 8.5, so can go into 8.6 if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants