Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Explain Log Rate Spikes: Add option to view grouped analysis results. #140464

Merged

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Sep 12, 2022

Summary

Part of #138117.
This PR adds the grouping table to the explain log rate spikes UI.

  • table row only shows the fieldName/fieldValue pairs that are not the same among all groups - helping to highlight important key/value pairs
  • expanded row shows all fieldName/fieldValue pairs in the group as a table view (like the current significant terms table) displaying the individual fieldName/fieldValue pairs along with the data we already have from the initial analysis (pValue, mini histogram, etc)

Each row contains the group (only the differing fieldName/fieldValue pairs - values that are the same among all the groups will only be shown in the expanded row) and doc count:

image

With badges:

image

Expanded row (for now) shows all fieldName/fieldValue pairs in that group:

image

Switch to ungroup view:

image

Checklist

Delete any items that are not applicable to this PR.

@@ -171,7 +251,18 @@ export const ExplainLogRateSpikesAnalysis: FC<ExplainLogRateSpikesAnalysisProps>
<EuiSpacer size="xs" />
</>
)}
{showSpikeAnalysisTable && (
{showSpikeAnalysisTable && !showUngrouped ? (
<SpikeAnalysisGroupsTable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would a link to Discover for the group level add any value - like Show all docs with this set of common attributes? Hard to tell with just the mock data.

image

Copy link
Contributor Author

@alvarezmelissa87 alvarezmelissa87 Sep 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to internal meta issue as a follow up 👍

{ defaultMessage: 'Group' }
),
render: (_, { group }) => (
<EuiCodeBlock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intention for the code block to fill all the available width per row? I am not seeing that:

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON has been removed and badges used instead.

@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-aiops-grouping-table-part-one branch from de9e992 to 7181b26 Compare September 14, 2022 17:12
@alvarezmelissa87 alvarezmelissa87 marked this pull request as ready for review September 14, 2022 17:53
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner September 14, 2022 17:53
@alvarezmelissa87 alvarezmelissa87 added release_note:enhancement v8.5.0 Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis labels Sep 14, 2022
@alvarezmelissa87 alvarezmelissa87 changed the title WIP [ML] Explain Log Rate Spikes: sample groups table view [ML] Explain Log Rate Spikes: sample groups table view Sep 14, 2022
@alvarezmelissa87
Copy link
Contributor Author

This has been updated and is ready for a look when you get a chance 🙏 cc @walterra, @peteharverson

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
aiops 362 364 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 480.6KB 490.0KB +9.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like spike_analysis_table_expanded_row.tsx is almost an exact copy of spike_analysis_table.tsx, can we try to reuse it and not duplicate the whole component? Let's do that in a follow up though! LGTM inluding local testing.

@alvarezmelissa87 alvarezmelissa87 merged commit af73375 into elastic:main Sep 15, 2022
@alvarezmelissa87 alvarezmelissa87 deleted the ml-aiops-grouping-table-part-one branch September 15, 2022 13:52
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 15, 2022
@walterra walterra changed the title [ML] Explain Log Rate Spikes: sample groups table view [ML] Explain Log Rate Spikes: Add option to view grouped analysis results. Sep 21, 2022
@walterra walterra added release_note:feature Makes this part of the condensed release notes :ml and removed release_note:enhancement labels Sep 21, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:feature Makes this part of the condensed release notes v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants