-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Explain Log Rate Spikes: Add option to view grouped analysis results. #140464
[ML] Explain Log Rate Spikes: Add option to view grouped analysis results. #140464
Conversation
@@ -171,7 +251,18 @@ export const ExplainLogRateSpikesAnalysis: FC<ExplainLogRateSpikesAnalysisProps> | |||
<EuiSpacer size="xs" /> | |||
</> | |||
)} | |||
{showSpikeAnalysisTable && ( | |||
{showSpikeAnalysisTable && !showUngrouped ? ( | |||
<SpikeAnalysisGroupsTable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to internal meta issue as a follow up 👍
{ defaultMessage: 'Group' } | ||
), | ||
render: (_, { group }) => ( | ||
<EuiCodeBlock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSON has been removed and badges used instead.
de2e940
to
8f94e1e
Compare
de9e992
to
7181b26
Compare
This has been updated and is ready for a look when you get a chance 🙏 cc @walterra, @peteharverson |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like spike_analysis_table_expanded_row.tsx
is almost an exact copy of spike_analysis_table.tsx
, can we try to reuse it and not duplicate the whole component? Let's do that in a follow up though! LGTM inluding local testing.
Pinging @elastic/ml-ui (:ml) |
Summary
Part of #138117.
This PR adds the grouping table to the explain log rate spikes UI.
Each row contains the group (only the differing fieldName/fieldValue pairs - values that are the same among all the groups will only be shown in the expanded row) and doc count:
With badges:
Expanded row (for now) shows all fieldName/fieldValue pairs in that group:
Switch to ungroup view:
Checklist
Delete any items that are not applicable to this PR.