Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mappings Editor] allow time series related properties #140278

Merged

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Sep 8, 2022

Summary

Fix #139922

This pr adds a definition for time_series properties to the mappings editor.
This allows the creation of a template for time series data streams using the Load JSON functionality.
Note: this pr doesn't make these fields configurable through the UI - this should be addressed separately.

The docs for new properties are here:

You can test using this example template (try to create it through the UI and Load JSON for mappings): https://github.com/csoulios/downsampling-demo/blob/1e66a13bccc7d70aae7763bcc9c4499ec8b3fd02/downsample-ilm.es#L26-L169

@Dosant Dosant added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Team:AppServicesSv release_note:skip Skip the PR/issue when compiling release notes Feature:Mappings Editor Index mappings editor UI v8.5.0 labels Sep 8, 2022
@Dosant Dosant marked this pull request as ready for review September 8, 2022 14:36
@Dosant Dosant requested a review from a team as a code owner September 8, 2022 14:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@Dosant
Copy link
Contributor Author

Dosant commented Sep 12, 2022

@elasticmachine merge upstream

@yuliacech
Copy link
Contributor

Hey @Dosant, thank you so much for adding the time series params!
I've been testing locally and I'm not sure that for time_series_metric this is the correct schema

schema: t.union([
      t.literal('gauge'),
      t.literal('counter'),
      t.literal('histogram'),
      t.literal('summary'),
      t.null,
    ]),

When I used histogram, the template creation failed with the following error: Failed to parse mapping: Unknown value [histogram] for field [time_series_metric] - accepted values are [gauge, counter]

@Dosant
Copy link
Contributor Author

Dosant commented Sep 13, 2022

@yuliacech, thanks for catching this. they were removed: elastic/elasticsearch#89937
I'll update

@Dosant Dosant requested a review from yuliacech September 13, 2022 10:20
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating, @Dosant!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 522.8KB 523.0KB +243.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit 8e5ed87 into elastic:main Sep 13, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Mappings Editor Index mappings editor UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mappings Editor] allow time series related properties
6 participants