Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] support multiple metrics in partition charts #140235

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented Sep 8, 2022

Summary

Resolve #8143

Screen.Recording.2022-09-07.at.8.11.53.PM.mov

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@drewdaemon drewdaemon added ci:cloud-deploy Create or update a Cloud deployment Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Sep 8, 2022
@drewdaemon drewdaemon changed the title [Lens] [PoC] support field groups in partition charts using existing UI [Lens] partition charts by field Sep 12, 2022
@drewdaemon drewdaemon changed the title [Lens] partition charts by field [Lens] support multiple metrics in partition charts Sep 13, 2022
@drewdaemon
Copy link
Contributor Author

Closing in favor of a different approach

@drewdaemon drewdaemon closed this Sep 19, 2022
@drewdaemon drewdaemon reopened this Sep 20, 2022
…eld-groups-in-partition-charts-same-interface-strategy
@drewdaemon drewdaemon force-pushed the 8143/support-field-groups-in-partition-charts-same-interface-strategy branch from 0b8c00d to 0304f96 Compare September 22, 2022 16:38
@spalger
Copy link
Contributor

spalger commented Sep 22, 2022

@elasticmachine merge upstream

(to resolve ci issues caused by Github outage)

@drewdaemon drewdaemon force-pushed the 8143/support-field-groups-in-partition-charts-same-interface-strategy branch from d6eb9e9 to 8fdf1f0 Compare October 21, 2022 22:37
…eld-groups-in-partition-charts-same-interface-strategy
@drewdaemon drewdaemon force-pushed the 8143/support-field-groups-in-partition-charts-same-interface-strategy branch from 8fdf1f0 to 483d9d2 Compare October 21, 2022 22:37
@drewdaemon drewdaemon removed the ci:cloud-deploy Create or update a Cloud deployment label Oct 24, 2022
@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 24, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #2 / Alerts detection rules table auto-refresh should disable auto refresh when any rule selected and enable it after rules unselected
  • [job] [logs] FTR Configs #43 / visualize app - new charts library visualize pie chart multi series slice should correctly filter on legend
  • [job] [logs] FTR Configs #43 / visualize app - new charts library visualize pie chart multi series slice should correctly filter on legend
  • [job] [logs] FTR Configs #43 / visualize app - new charts library visualize pie chart multi series slice should show correct chart
  • [job] [logs] FTR Configs #43 / visualize app - new charts library visualize pie chart multi series slice should show correct chart

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cases 507 500 -7
data 521 520 -1
embeddable 79 84 +5
expressionPartitionVis 100 102 +2
files 68 41 -27
infra 1012 1008 -4
lens 959 943 -16
synthetics 1022 1021 -1
total -49

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2523 2517 -6
embeddable 410 412 +2
expressionPartitionVis 70 75 +5
files 18 14 -4
lens 581 580 -1
visualizations 729 730 +1
total -3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.0MB 1.0MB +1.0B
cases 374.6KB 372.9KB -1.6KB
cloudGainsight 2.4KB 2.4KB -62.0B
controls 492.2KB 491.5KB -706.0B
dataViewEditor 34.7KB 34.7KB -5.0B
expressionPartitionVis 51.0KB 52.2KB +1.2KB
files 25.7KB 9.0KB -16.8KB
infra 1009.4KB 1.0MB +18.8KB
lens 1.3MB 1.3MB -8.8KB
maps 2.7MB 2.7MB +39.0B
ml 3.4MB 3.4MB -9.2KB
observability 520.6KB 520.8KB +156.0B
osquery 1.0MB 1.0MB +6.0B
securitySolution 9.5MB 9.5MB -33.0B
synthetics 1.0MB 1.0MB -464.0B
ux 162.8KB 162.9KB +3.0B
visualizations 268.1KB 268.2KB +66.0B
total -17.5KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
lens 47 45 -2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 126.1KB 126.1KB -1.0B
controls 18.4KB 18.4KB -56.0B
core 367.3KB 367.3KB -69.0B
data 439.0KB 437.6KB -1.4KB
embeddable 68.9KB 70.1KB +1.1KB
expressionPartitionVis 23.8KB 23.8KB +75.0B
expressions 98.0KB 97.6KB -465.0B
files 19.5KB 18.9KB -573.0B
guidedOnboarding 21.4KB 21.4KB +19.0B
kbnUiSharedDeps-npmDll 5.0MB 5.0MB +8.0B
kbnUiSharedDeps-srcJs 3.8MB 3.8MB +4.0B
lens 29.2KB 29.2KB -1.0B
maps 82.1KB 82.1KB -8.0B
observability 68.0KB 67.6KB -423.0B
visTypePie 12.2KB 12.2KB +15.0B
total -1.7KB
Unknown metric groups

API count

id before after diff
data 3251 3245 -6
embeddable 510 512 +2
expressionPartitionVis 70 75 +5
files 272 260 -12
ml 254 251 -3
visualizations 759 760 +1
total -13

async chunk count

id before after diff
files 2 1 -1

ESLint disabled in files

id before after diff
files 4 3 -1

References to deprecated APIs

id before after diff
maps 21 77 +56
observability 64 24 -40
total +16

Total ESLint disabled count

id before after diff
files 7 6 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon force-pushed the 8143/support-field-groups-in-partition-charts-same-interface-strategy branch from cca280b to ca81292 Compare October 25, 2022 15:05
@drewdaemon drewdaemon changed the base branch from main to 8.5 October 25, 2022 15:19
@drewdaemon drewdaemon changed the base branch from 8.5 to main October 25, 2022 15:19
@drewdaemon drewdaemon closed this Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pie chart as sum of multiple fields
4 participants