Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Index Template] Fix previewing data streams in template editor #140189

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -588,4 +588,33 @@ describe('<TemplateCreate />', () => {
expect(find('saveTemplateError').text()).toContain(error.message);
});
});

test('preview data stream', async () => {
await act(async () => {
testBed = await setup(httpSetup);
});
testBed.component.update();

const { actions } = testBed;
// Logistics
await actions.completeStepOne({
name: TEMPLATE_NAME,
indexPatterns: DEFAULT_INDEX_PATTERNS,
dataStream: {},
});

await act(async () => {
await actions.previewTemplate();
});

expect(httpSetup.post).toHaveBeenLastCalledWith(
`${API_BASE_PATH}/index_templates/simulate`,
expect.objectContaining({
body: JSON.stringify({
index_patterns: DEFAULT_INDEX_PATTERNS,
data_stream: {},
}),
})
);
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ export const formSetup = async (initTestBed: SetupFunc<TestSubjects>) => {
order,
priority,
version,
dataStream,
}: Partial<TemplateDeserialized> = {}) => {
const { component, form, find } = testBed;

Expand All @@ -162,6 +163,10 @@ export const formSetup = async (initTestBed: SetupFunc<TestSubjects>) => {
form.setInputValue('orderField.input', JSON.stringify(order));
}

if (dataStream) {
form.toggleEuiSwitch('dataStreamField.input');
}

if (priority) {
form.setInputValue('priorityField.input', JSON.stringify(priority));
}
Expand Down Expand Up @@ -255,6 +260,10 @@ export const formSetup = async (initTestBed: SetupFunc<TestSubjects>) => {
component.update();
};

const previewTemplate = async () => {
testBed.find('previewIndexTemplate').simulate('click');
};

return {
...testBed,
actions: {
Expand All @@ -272,6 +281,7 @@ export const formSetup = async (initTestBed: SetupFunc<TestSubjects>) => {
componentTemplates,
mappings,
review,
previewTemplate,
},
};
};
Expand Down Expand Up @@ -317,6 +327,7 @@ export type TestSubjects =
| 'orderField'
| 'orderField.input'
| 'priorityField.input'
| 'dataStreamField.input'
| 'pageTitle'
| 'previewTab'
| 'removeFieldButton'
Expand All @@ -341,4 +352,5 @@ export type TestSubjects =
| 'settingsEditor'
| 'versionField.input'
| 'mappingsEditor.formTab'
| 'mappingsEditor.advancedConfiguration.sizeEnabledToggle';
| 'mappingsEditor.advancedConfiguration.sizeEnabledToggle'
| 'previewIndexTemplate';
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ export const SimulateTemplate = React.memo(({ template, filters }: Props) => {
return;
}

const indexTemplate = serializeTemplate(stripEmptyFields(template) as TemplateDeserialized);
const indexTemplate = serializeTemplate(
stripEmptyFields(template, { types: ['string'] }) as TemplateDeserialized
);
const { data, error } = await simulateIndexTemplate(indexTemplate);
let filteredTemplate = data;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ export const TemplateForm = ({
}

return (
<EuiButton size="s" onClick={showPreviewFlyout}>
<EuiButton size="s" onClick={showPreviewFlyout} data-test-subj="previewIndexTemplate">
<FormattedMessage
id="xpack.idxMgmt.templateForm.previewIndexTemplateButtonLabel"
defaultMessage="Preview index template"
Expand Down