[Actionable Observability] Update links to Observability rule management #140009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoenWarmer
force-pushed
the
chore/138893-update-ao-links-going-to-stack-management
branch
from
fadf795 to
3d06e84
Compare
CoenWarmer
changed the title
CoenWarmer
changed the title
maryam-saeidi
added
release_note:fix
Team: Actionable Observability - DEPRECATED
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
| @@ -135,7 +135,7 @@ export const getContent = ( | |||
| addTitle: i18n.translate('xpack.observability.statusVisualization.alert.link', { | |||
| defaultMessage: 'Create rules', | |||
| }), | |||
| addLink: http.basePath.prepend('/app/management/insightsAndAlerting/triggersActions/rules'), | |||
| addLink: http.basePath.prepend('/app/observability/alerts'), | |||
There was a problem hiding this comment.
@CoenWarmer we need to go to /observability/alerts/rules instead of /observability/alerts
There was a problem hiding this comment.
You're right of course!
| @@ -97,7 +97,7 @@ export const getEmptySections = ({ http }: { http: HttpSetup }): ISection[] => { | |||
| linkTitle: i18n.translate('xpack.observability.emptySection.apps.alert.link', { | |||
| defaultMessage: 'Create rule', | |||
| }), | |||
| href: http.basePath.prepend('/app/management/insightsAndAlerting/triggersActions/alerts'), | |||
There was a problem hiding this comment.
Also, I am wondering why this one goes to /alerts. From the ticket, it seems all the places are redirected to /rules not /alerts 🤔
There was a problem hiding this comment.
Have updated to /rules for now.
… of github.com:CoenWarmer/kibana into chore/138893-update-ao-links-going-to-stack-management
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.5.0
backport:skip
Mpdreamz
pushed a commit
to Mpdreamz/kibana
that referenced
this pull request
Sep 6, 2022
…ent (elastic#140009) * [Actionable Observability] Update links to Observability rule management * Use path config file for links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates links in the Observability Overview from the Stack Management Rules configuration view to the Observability Rules screen.
Resolves 138893.