[Discover] Advanced integration of adhoc Data Views

[dimaanj]

Summary

Follow up of #138283

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 5718127

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
discover	527	530	+3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
discover	78	79	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
dataViewEditor	31.9KB	31.9KB	+6.0B
discover	463.1KB	467.8KB	+4.7KB
lens	1.2MB	1.2MB	-20.0B
total			+4.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
data	430.6KB	430.7KB	+147.0B
discover	26.1KB	26.2KB	+130.0B
maps	81.2KB	81.2KB	+2.0B
total			+279.0B

Unknown metric groups

API count

id	before	after	diff
discover	95	96	+1

ESLint disabled line counts

id	before	after	diff
data	46	47	+1
discover	37	38	+1
total			+2

References to deprecated APIs

id	before	after	diff
lens	4	3	-1

Total ESLint disabled count

id	before	after	diff
data	48	49	+1
discover	38	39	+1
total			+2

History

• 💚 Build #70079 succeeded 53150b9
• 💚 Build #70003 succeeded 50831d9
• 💚 Build #69705 succeeded 7b9b70a
• 💚 Build #69626 succeeded a52c36b
• 💔 Build #69596 failed 4481b90
• 💔 Build #69278 failed 9c47b85

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dimaanj

[dimaanj]

Closing it, since #140885 created instead