[RAM] add refresh functionality to alert table #139669
Conversation
XavierM
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
@maryam-saeidi, can you please check if this PR do what you expected? thanks in advance! |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @XavierM |
| if (!isLoading && refreshNow) { | ||
| refresh(); | ||
| } | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
nitpick: do we need this eslint-disable since we're actually referencing refreshNow in the effect, also does this have a stale reference to isLoading since it's not a dependency?
There was a problem hiding this comment.
The array of dependency plays no direct role in ensuring that the effect runs with fresh values (the effect always runs with the value at the time the component is rendered). The array only controls when the effect runs.
https://blog.bitsrc.io/understanding-dependencies-in-useeffect-7afd4df37c96
* add refresh functionality to alert table * add exhaustive deps * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit b1f5030)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
* add refresh functionality to alert table * add exhaustive deps * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit b1f5030) Co-authored-by: Xavier Mouligneau <[email protected]>
* add refresh functionality to alert table * add exhaustive deps * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' Co-authored-by: kibanamachine <[email protected]>
Summary
We need user of the alert table to be able to refresh the alert table when they want. To do that we added a new prop
refreshNowand we expect this value to be set likenew Date().getTime()and each time this prop changed, then we will re-run the query with the same parameter.#134892
Checklist