Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Fix flaky policy tests #139660

Merged
merged 11 commits into from
Aug 30, 2022

Conversation

kevinlog
Copy link
Contributor

@kevinlog kevinlog commented Aug 29, 2022

Summary

Addresses test failures from these tickets:
#101024
#100236
#92567

This also addresses some additional flakiness that I found when running this suite through the flakey test runner. Specifically, the check to reduce the transform time was occasionally flakey and no longer needed since our transforms run much faster after the change to use the united index.

In addition, this deletes a long skipped flakey test which jumps back and forth between Fleet and Security.

A "bad" flakey test run to show the results before these changes: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1109#_

A "good" flakey test run after these changes are added: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1111

Checklist

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kevinlog kevinlog added Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.5.0 release_note:skip Skip the PR/issue when compiling release notes labels Aug 30, 2022
@kevinlog kevinlog marked this pull request as ready for review August 30, 2022 17:18
@kevinlog kevinlog requested a review from a team as a code owner August 30, 2022 17:18
@kevinlog kevinlog requested review from pzl and parkiino August 30, 2022 17:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

Copy link
Member

@pzl pzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okie dokie

Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants