Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for loading before asserting filters #139162

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Wait for loading before asserting filters #139162

merged 2 commits into from
Aug 23, 2022

Conversation

flash1293
Copy link
Contributor

Fixes #139096
Fixes #139114

The tests failed because in

kibana/test/functional/apps/visualize/group5/_tsvb_time_series.ts

Line 232 in 4971395

const filterPills = await filterBar.getFiltersLabel();
it would apply a filter, then immediately check for the filter labels while they were rendering. This PR makes sure to wait for the dashboard to stabilize before asserting again.

@flash1293 flash1293 added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Aug 19, 2022
@flash1293 flash1293 marked this pull request as ready for review August 19, 2022 11:24
@flash1293 flash1293 requested a review from a team as a code owner August 19, 2022 11:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@mbondyra
Copy link
Contributor

@elasticmachine merge upstream

mbondyra
mbondyra approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🆗

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra mbondyra merged commit 9358fdc into elastic:main Aug 23, 2022
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
@flash1293 @kibanamachine @Mpdreamz
wait for loading before asserting filters (elastic#139162)
404f586 
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.5.0
Projects
None yet
Milestone
No milestone
5 participants
@flash1293 @elasticmachine @mbondyra @kibana-ci @kibanamachine