Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cloud test failures for 8.4 #139155

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Fix cloud test failures for 8.4 #139155

merged 2 commits into from
Aug 22, 2022

Conversation

liza-mae
Copy link
Contributor

@liza-mae liza-mae commented Aug 18, 2022 •
edited
Loading

Fixes

Reporting

  • I am skipping a test that is looking for configuration settings on the server because I am assuming on cloud those settings will not be visible so this test is not applicable. Someone from the reporting team will need to confirm if this is correct or a bug.
  • For another test I increased the timeout, as it takes a bit longer on cloud

Dashboard Tests

  • Added security roles to dashboard tests

Management Test

  • Added a wait for page to load to the management test

@liza-mae liza-mae added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.4.0 v8.5.0 labels Aug 18, 2022
@liza-mae liza-mae self-assigned this Aug 18, 2022
@liza-mae liza-mae requested review from a team as code owners August 18, 2022 23:12
Heenawter
Heenawter approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code only review - added security roles to recently added Dashboard tests. Thanks so much for fixing this - everything looks good! 👍

@liza-mae
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @liza-mae

tsullivan
tsullivan reviewed Aug 22, 2022
View reviewed changes
x-pack/test/reporting_api_integration/reporting_and_security/validation.ts
@@ -43,7 +43,7 @@ export default function ({ getService }: FtrProviderContext) {
{ jobParams: createPdfV2Params(1541.5999755859375) }
);

await retry.tryForTime(48000, async () => {
await retry.tryForTime(60000, async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this to resolve #139142 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I noticed this test takes a bit longer on cloud, so I increased the retry.

@liza-mae liza-mae merged commit 6e87b01 into elastic:main Aug 22, 2022
@liza-mae liza-mae deleted the liza/fix-cloud-tests branch August 22, 2022 23:52
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.4 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.4:
- [Archive Migrations] reporting-ecommerce_kibana_spaces - using an api in conjuction with migration (#136288)

Manual backport

To create the backport manually run:

node scripts/backport --pr 139155

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@liza-mae liza-mae mentioned this pull request Aug 23, 2022
Merged
@liza-mae
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

liza-mae added a commit that referenced this pull request Aug 23, 2022
@liza-mae
Fix cloud test failures for 8.4 (#139155) (#139259)
28c5a8c 
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 6e87b01)
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
@liza-mae @kibanamachine @Mpdreamz
Fix cloud test failures for 8.4 (elastic#139155)
1922fe4 
Co-authored-by: Kibana Machine <[email protected]>
This was referenced Sep 15, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@liza-mae liza-mae mentioned this pull request Sep 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsullivan tsullivan tsullivan approved these changes

@Heenawter Heenawter Heenawter approved these changes

@vadimkibana vadimkibana vadimkibana approved these changes

Assignees

@liza-mae liza-mae

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v8.4.0 v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liza-mae @kibana-ci @kibanamachine @tsullivan @Heenawter @vadimkibana